Optimize function at its entry instead of at exit.

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 42 matching lines @@
     } else {
       ASSERT(value.IsStackSlot());
       __ pushq(value.ToStackSlotAddress());
     }
   }
 }
 
 
 LocationSummary* ReturnInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
-  const intptr_t kNumTemps = 1;
+  const intptr_t kNumTemps = 0;
   LocationSummary* locs =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
   locs->set_in(0, Location::RegisterLocation(RAX));
-  locs->set_temp(0, Location::RegisterLocation(RDX));
   return locs;
 }
 
 
 // Attempt optimized compilation at return instruction instead of at the entry.
 // The entry needs to be patchable, no inlined objects are allowed in the area
 // that will be overwritten by the patch instruction: a jump).
 void ReturnInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
-  const Function& function =
-      Function::ZoneHandle(compiler->parsed_function().function().raw());
   Register result = locs()->in(0).reg();
-  Register func_reg = locs()->temp(0).reg();
   ASSERT(result == RAX);
-  if (compiler->is_optimizing()) {
-    if (compiler->may_reoptimize()) {
-      // Increment of counter occurs only in optimized IC calls, as they
-      // can cause reoptimization.
-      Label done;
-      __ LoadObject(func_reg, function);
-      __ cmpq(FieldAddress(func_reg, Function::usage_counter_offset()),
-          Immediate(FLAG_optimization_counter_threshold));
-      __ j(LESS, &done, Assembler::kNearJump);
-      // Equal (or greater), optimize. Note that counter can reach equality
-      // only at return instruction.
-      // The stub call preserves result register (EAX).
-      ASSERT(func_reg == RDX);
-      compiler->GenerateCall(0,  // no token position.
-                             &StubCode::OptimizeFunctionLabel(),
-                             PcDescriptors::kOther,
-                             locs());
-      __ Bind(&done);
-    }
-  } else {
-    __ Comment("Check function counter");
-    // Count only in unoptimized code.
-    // TODO(srdjan): Replace the counting code with a type feedback
-    // collection and counting stub.
-    __ LoadObject(func_reg, function);
-    __ incq(FieldAddress(func_reg, Function::usage_counter_offset()));
-    if (compiler->CanOptimizeFunction() &&
-        compiler->parsed_function().function().is_optimizable()) {
-      // Do not optimize if usage count must be reported.
-      __ cmpq(FieldAddress(func_reg, Function::usage_counter_offset()),
-          Immediate(FLAG_optimization_counter_threshold));
-      Label not_yet_hot;
-      __ j(LESS, &not_yet_hot, Assembler::kNearJump);
-      // Equal (or greater), optimize.
-      // The stub call preserves result register(RAX)
-      ASSERT(func_reg == RDX);
-      compiler->GenerateCall(0,  // no token position.
-                             &StubCode::OptimizeFunctionLabel(),
-                             PcDescriptors::kOther,
-                             locs());
-      __ Bind(&not_yet_hot);
-    }
-  }
 #if defined(DEBUG)
   // TODO(srdjan): Fix for functions with finally clause.
   // A finally clause may leave a previously pushed return value if it
   // has its own return instruction. Method that have finally are currently
   // not optimized.
   if (!compiler->HasFinally()) {
     Label done;
     __ movq(RDI, RBP);
     __ subq(RDI, RSP);
     // + 1 for Pc marker.
@@ skipping 2354 matching lines @@
 
 void ShiftMintOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   UNIMPLEMENTED();
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64