Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: utils/pub/utils.dart

Issue 11783009: Big merge from experimental to bleeding edge. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/system_cache.dart ('k') | utils/pub/validator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/utils.dart
diff --git a/utils/pub/utils.dart b/utils/pub/utils.dart
index 557e67de027c9164aeed0c2990425d62105a84c6..b922d845d4013de9e3132acb6033f3e2e5fa86b4 100644
--- a/utils/pub/utils.dart
+++ b/utils/pub/utils.dart
@@ -5,6 +5,7 @@
/// Generic utility functions. Stuff that should possibly be in core.
library utils;
+import 'dart:async';
import 'dart:crypto';
import 'dart:isolate';
import 'dart:uri';
@@ -42,17 +43,12 @@ String padRight(String source, int length) {
/// Runs [fn] after [future] completes, whether it completes successfully or
/// not. Essentially an asynchronous `finally` block.
always(Future future, fn()) {
- var completer = new Completer();
- future.then((_) => fn());
- future.handleException((_) {
- fn();
- return false;
- });
+ future.catchError((_) {}).then((_) => fn());
}
-/// Flattens nested collections into a single list containing only non-list
-/// elements.
-List flatten(Collection nested) {
+/// Flattens nested lists inside an iterable into a single list containing only
+/// non-list elements.
+List flatten(Iterable nested) {
var result = [];
helper(list) {
for (var element in list) {
@@ -69,10 +65,11 @@ List flatten(Collection nested) {
/// Asserts that [iter] contains only one element, and returns it.
only(Iterable iter) {
- var iterator = iter.iterator();
- assert(iterator.hasNext);
- var obj = iterator.next();
- assert(!iterator.hasNext);
+ var iterator = iter.iterator;
+ var currentIsValid = iterator.moveNext();
+ assert(currentIsValid);
+ var obj = iterator.current;
+ assert(!iterator.moveNext());
return obj;
}
@@ -108,7 +105,7 @@ bool endsWithPattern(String str, Pattern matcher) {
/// Returns the hex-encoded sha1 hash of [source].
String sha1(String source) =>
- CryptoUtils.bytesToHex(new SHA1().update(source.charCodes).digest());
+ CryptoUtils.bytesToHex(new SHA1().add(source.charCodes).close());
/// Returns a [Future] that completes in [milliseconds].
Future sleep(int milliseconds) {
@@ -120,11 +117,11 @@ Future sleep(int milliseconds) {
/// Configures [future] so that its result (success or exception) is passed on
/// to [completer].
void chainToCompleter(Future future, Completer completer) {
- future.handleException((e) {
- completer.completeException(e, future.stackTrace);
- return true;
- });
- future.then(completer.complete);
+ future
+ .then(completer.complete)
+ .catchError((e) {
+ completer.completeError(e.error, e.stackTrace);
+ });
}
// TODO(nweiz): unify the following functions with the utility functions in
@@ -171,7 +168,7 @@ String mapToQuery(Map<String, String> map) {
value = (value == null || value.isEmpty) ? null : encodeUriComponent(value);
pairs.add([key, value]);
});
- return Strings.join(pairs.map((pair) {
+ return Strings.join(pairs.mappedBy((pair) {
if (pair[1] == null) return pair[0];
return "${pair[0]}=${pair[1]}";
}), "&");
« no previous file with comments | « utils/pub/system_cache.dart ('k') | utils/pub/validator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698