Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1178293004: Port sky_home to the new SkyView world (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel, eseidel1, Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -88 lines) Patch
M sky/apk/demo/org/domokit/sky/demo/SkyDemoActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/game/main.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/rendering/borders.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/rendering/interactive_flex.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/rendering/justify_content.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/rendering/render_paragraph.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/rendering/sector_layout.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/rendering/shadowed_box.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/rendering/spinning_flex.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/rendering/touch_demo.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/rendering/transform.dart View 1 chunk +1 line, -1 line 0 comments Download
A sky/home.dart View 1 chunk +83 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/widgets/tool_bar.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M sky/sdk/lib/framework/widgets/wrappers.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/ios/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
D sky/sky_home View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/sky_home.dart View 1 chunk +0 lines, -56 lines 0 comments Download
M sky/tools/shelldb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
5 years, 6 months ago (2015-06-12 23:43:35 UTC) #1
eseidel1
lgtm
5 years, 6 months ago (2015-06-12 23:49:57 UTC) #3
Hixie
lgtm
5 years, 6 months ago (2015-06-12 23:52:41 UTC) #5
abarth-chromium
5 years, 6 months ago (2015-06-12 23:53:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cb50006be9f35873e383080ae87f7d891c8d97aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698