Source/core/frame/PinchViewport.cpp - Issue 1178273008: Fix PinchViewport::visibleRectInDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/PinchViewport.cpp

Issue 1178273008: Fix PinchViewport::visibleRectInDocument (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/PinchViewport.cpp

diff --git a/Source/core/frame/PinchViewport.cpp b/Source/core/frame/PinchViewport.cpp

index 73b443b684c7fc3c8dea81644d36bdb38185d9d5..4b20bc08d9ebbdac6c12b02cd6552e09909130d8 100644

--- a/Source/core/frame/PinchViewport.cpp

+++ b/Source/core/frame/PinchViewport.cpp

@@ -146,9 +146,7 @@ FloatRect PinchViewport::visibleRectInDocument() const

return FloatRect();

FloatPoint viewLocation = FloatPoint(mainFrame()->view()->scrollableArea()->scrollPositionDouble());

- FloatRect pinchRect = visibleRect();

- pinchRect.moveBy(viewLocation);

- return pinchRect;

+ return FloatRect(viewLocation, visibleSize());

}

FloatRect PinchViewport::mainViewToViewportCSSPixels(const FloatRect& rect) const

« no previous file with comments | « no previous file | Source/web/tests/PinchViewportTest.cpp » ('j') | no next file with comments »