Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(36)

Issue 1178273008: Fix PinchViewport::visibleRectInDocument (Closed)

Created:
4 years, 10 months ago by bokan
Modified:
4 years, 10 months ago
Reviewers:
mustaq
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix PinchViewport::visibleRectInDocument This method needs to return the visual viewport rect relative to the document origin. Introducing the RootFrameViewport in r194957 meant that frameView->scrollableArea()->scrollPositionDouble() went from being the offset of just the layout viewport to being the visual viewport offset. This method wasn't updated at the time so it erroneously moves the returned offset by the visual viewport offset. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M Source/core/frame/PinchViewport.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bokan
Hi Mustaq, ptal. The scrollPositionDouble call in this method calls RootFrameViewport::scrollPositionDouble https://code.google.com/p/chromium/codesearch/#chromium/src/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp&l=212&q=RootFrameViewport::scrollPositionDouble&type=cs&sq=package:chromium As you can ...
4 years, 10 months ago (2015-06-17 20:09:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178273008/1
4 years, 10 months ago (2015-06-18 19:29:52 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-18 20:58:29 UTC) #6
mustaq
lgtm
4 years, 10 months ago (2015-06-19 13:58:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178273008/1
4 years, 10 months ago (2015-06-19 14:30:56 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 14:34:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197473

Powered by Google App Engine
This is Rietveld 408576698