Issue 1178273002: Remove dead DataView IDL and C++ code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178273002: Remove dead DataView IDL and C++ code (Closed)

Created:
4 years, 10 months ago by adamk

Modified:
4 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Rik, Inactive, dglazkov+blink, dshwang, eae+blinkwatch, Justin Novosad, rwlbuis, sof, vivekg_samsung, vivekg

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove dead DataView IDL and C++ code Also get rid of html/canvas/DataView.{h,cpp} and make DataView private to DOMDataView's implementation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197053

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -323 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/DOMDataView.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	Source/core/dom/DOMDataView.cpp	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	Source/core/dom/DataView.idl	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	Source/core/html/canvas/DataView.h	View	1 chunk	+0 lines, -76 lines	0 comments	Download
D	Source/core/html/canvas/DataView.cpp	View	1 chunk	+0 lines, -218 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178273002/1

4 years, 10 months ago (2015-06-12 18:00:07 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-12 19:00:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197053

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages