content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 1178253005: Use Chromium's logging utility for content files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1178253005: Use Chromium's logging utility for content files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java ('k') | content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 1ebd4298cd2e94b45f8caf0b1a45f58cd6e804d2..cd33edb7d971c9424977be307664de1dbc03595e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -27,7 +27,6 @@ import android.provider.Browser;

import android.text.Editable;

import android.text.Selection;

import android.text.TextUtils;

-import android.util.Log;

import android.util.Pair;

import android.view.HapticFeedbackConstants;

import android.view.InputDevice;

@@ -47,6 +46,7 @@ import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.CalledByNative;

import org.chromium.base.CommandLine;

import org.chromium.base.JNINamespace;

+import org.chromium.base.Log;

import org.chromium.base.ObserverList;

import org.chromium.base.ObserverList.RewindableIterator;

import org.chromium.base.TraceEvent;

@@ -101,7 +101,7 @@ public class ContentViewCore implements

AccessibilityStateChangeListener, ScreenOrientationObserver,

SystemCaptioningBridge.SystemCaptioningBridgeListener {

- private static final String TAG = "ContentViewCore";

+ private static final String TAG = "cr.ContentViewCore";

// Used to avoid enabling zooming in / out if resulting zooming will

// produce little visible difference.

@@ -259,7 +259,7 @@ public class ContentViewCore implements

scaledWidth, (int) (height * scale), leftMargin, topMargin);

view.setLayoutParams(lp);

} else {

- Log.e(TAG, "Unknown layout " + containerView.getClass().getName());

+ Log.e(TAG, "Unknown layout %s", containerView.getClass().getName());

}