Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java

Issue 1178253005: Use Chromium's logging utility for content files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java b/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
index e4a1c2769c55dce4178f50e7493309a7a556278d..3639191f35de484de5a8ef575179c1257042fdfb 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
@@ -9,7 +9,6 @@ import android.content.Context;
import android.content.DialogInterface;
import android.graphics.Point;
import android.provider.Settings;
-import android.util.Log;
import android.view.Display;
import android.view.Gravity;
import android.view.KeyEvent;
@@ -26,6 +25,7 @@ import android.widget.TextView;
import org.chromium.base.CalledByNative;
import org.chromium.base.JNINamespace;
+import org.chromium.base.Log;
import org.chromium.base.ThreadUtils;
/**
@@ -35,7 +35,7 @@ import org.chromium.base.ThreadUtils;
public class ContentVideoView extends FrameLayout
implements SurfaceHolder.Callback {
- private static final String TAG = "ContentVideoView";
+ private static final String TAG = "cr.ContentVideoView";
/* Do not change these values without updating their counterparts
* in include/media/mediaplayer.h!
@@ -218,7 +218,7 @@ public class ContentVideoView extends FrameLayout
@CalledByNative
public void onMediaPlayerError(int errorType) {
- Log.d(TAG, "OnMediaPlayerError: " + errorType);
+ Log.d(TAG, "OnMediaPlayerError: %d", errorType);
if (mCurrentState == STATE_ERROR || mCurrentState == STATE_PLAYBACK_COMPLETED) {
return;
}
@@ -267,7 +267,7 @@ public class ContentVideoView extends FrameLayout
.setCancelable(false)
.show();
} catch (RuntimeException e) {
- Log.e(TAG, "Cannot show the alert dialog, error message: " + message, e);
+ Log.e(TAG, "Cannot show the alert dialog, error message: %s", message, e);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698