Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 1178253005: Use Chromium's logging utility for content files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
index 8170a70bc3c757b7599f7856764755007cbb5132..674cf87a581df81136b0fc3d5694014de40a5fc5 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
@@ -184,7 +184,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
// Stash the status of the oom bindings, since stop() will release all bindings.
mWasOomProtected = isCurrentlyOomProtected();
mServiceDisconnected = true;
- Log.w(TAG, "onServiceDisconnected (crash or killed by oom): pid=" + mPid);
+ Log.w(TAG, "onServiceDisconnected (crash or killed by oom): pid=%d", mPid);
stop(); // We don't want to auto-restart on crash. Let the browser do that.
mDeathCallback.onChildProcessDied(ChildProcessConnectionImpl.this);
// If we have a pending connection callback, we need to communicate the failure to
@@ -413,7 +413,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
public void addStrongBinding() {
synchronized (mLock) {
if (mService == null) {
- Log.w(TAG, "The connection is not bound for " + mPid);
+ Log.w(TAG, "The connection is not bound for %d", mPid);
return;
}
if (mStrongBindingCount == 0) {
@@ -427,7 +427,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
public void removeStrongBinding() {
synchronized (mLock) {
if (mService == null) {
- Log.w(TAG, "The connection is not bound for " + mPid);
+ Log.w(TAG, "The connection is not bound for %d", mPid);
return;
}
assert mStrongBindingCount > 0;
@@ -449,7 +449,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
public void addModerateBinding() {
synchronized (mLock) {
if (mService == null) {
- Log.w(TAG, "The connection is not bound for " + mPid);
+ Log.w(TAG, "The connection is not bound for %d", mPid);
return;
}
mModerateBinding.bind(null);
@@ -460,7 +460,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
public void removeModerateBinding() {
synchronized (mLock) {
if (mService == null) {
- Log.w(TAG, "The connection is not bound for " + mPid);
+ Log.w(TAG, "The connection is not bound for %d", mPid);
return;
}
mModerateBinding.unbind();

Powered by Google App Engine
This is Rietveld 408576698