Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 1178253005: Use Chromium's logging utility for content files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
index e134d3625d3ab16879dfe1c59ed732eb93b97a4f..20a51e1e67e19d4b56824a4f240f0a19a1515396 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
@@ -12,9 +12,9 @@ import android.os.Bundle;
import android.os.DeadObjectException;
import android.os.IBinder;
import android.os.RemoteException;
-import android.util.Log;
import org.chromium.base.CpuFeatures;
+import org.chromium.base.Log;
import org.chromium.base.ThreadUtils;
import org.chromium.base.TraceEvent;
import org.chromium.base.VisibleForTesting;
@@ -69,7 +69,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
private final boolean mAlwaysInForeground;
- private static final String TAG = "ChildProcessConnection";
+ private static final String TAG = "cr.ChildProcessLaunch";
AKVT 2015/06/16 08:48:53 cr.ChildProcessConnection
private static class ConnectionParams {
final String[] mCommandLine;
@@ -180,7 +180,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
// Stash the status of the oom bindings, since stop() will release all bindings.
mWasOomProtected = isCurrentlyOomProtected();
mServiceDisconnected = true;
- Log.w(TAG, "onServiceDisconnected (crash or killed by oom): pid=" + mPid);
+ Log.w(TAG, "onServiceDisconnected (crash or killed by oom): pid= %d", mPid);
AKVT 2015/06/16 08:48:53 pid=%d
stop(); // We don't want to auto-restart on crash. Let the browser do that.
mDeathCallback.onChildProcessDied(ChildProcessConnectionImpl.this);
// If we have a pending connection callback, we need to communicate the failure to
@@ -405,7 +405,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
public void addStrongBinding() {
synchronized (mLock) {
if (mService == null) {
- Log.w(TAG, "The connection is not bound for " + mPid);
+ Log.w(TAG, "The connection is not bound for %d", mPid);
return;
}
if (mStrongBindingCount == 0) {
@@ -419,7 +419,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
public void removeStrongBinding() {
synchronized (mLock) {
if (mService == null) {
- Log.w(TAG, "The connection is not bound for " + mPid);
+ Log.w(TAG, "The connection is not bound for %d", mPid);
return;
}
assert mStrongBindingCount > 0;

Powered by Google App Engine
This is Rietveld 408576698