Chromium Code Reviews

Issue 1178223004: Sync some HTML interfaces with the spec (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, arv+blink, vivekg_samsung, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, eric.carlson_apple.com, vivekg, dglazkov+blink, Inactive
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync some HTML interfaces with the spec There are no changes to the generated code other than naming (ImageData) and order (MediaController). BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197008

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+46 lines, -21 lines)
M Source/core/html/ImageData.idl View 1 chunk +6 lines, -3 lines 0 comments
M Source/core/html/MediaController.idl View 1 chunk +10 lines, -4 lines 0 comments
M Source/core/html/MediaError.idl View 1 chunk +2 lines, -0 lines 0 comments
M Source/core/html/RadioNodeList.idl View 1 chunk +3 lines, -1 line 0 comments
M Source/core/html/TextMetrics.idl View 1 chunk +6 lines, -1 line 0 comments
M Source/core/html/TimeRanges.idl View 2 chunks +2 lines, -1 line 0 comments
M Source/core/html/ValidityState.idl View 1 chunk +13 lines, -11 lines 0 comments
M Source/core/html/VoidCallback.idl View 1 chunk +4 lines, -0 lines 0 comments

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178223004/1
5 years, 6 months ago (2015-06-11 20:32:24 UTC) #2
philipj_slow
PTAL
5 years, 6 months ago (2015-06-11 22:07:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-11 23:11:59 UTC) #6
Jens Widell
LGTM
5 years, 6 months ago (2015-06-12 05:52:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178223004/1
5 years, 6 months ago (2015-06-12 07:19:11 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 07:22:27 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197008

Powered by Google App Engine