Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1178203004: Componentize InMemoryURLIndexTypes (Closed)

Created:
5 years, 6 months ago by blundell
Modified:
5 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize InMemoryURLIndexTypes The code has no //chrome-level dependencies, so componentization is trivial. BUG=371538 Committed: https://crrev.com/2a4e23128433254f5bd6ff9d7260e365232dbd31 Cr-Commit-Position: refs/heads/master@{#334131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -498 lines) Patch
M chrome/browser/autocomplete/history_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/autocomplete/in_memory_url_index_types.h View 1 chunk +0 lines, -171 lines 0 comments Download
D chrome/browser/autocomplete/in_memory_url_index_types.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/autocomplete/in_memory_url_index_types_unittest.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/scored_history_match.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/url_index_private_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/omnibox/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A + components/omnibox/in_memory_url_index_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/in_memory_url_index_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/omnibox/in_memory_url_index_types_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
blundell
5 years, 6 months ago (2015-06-11 20:50:47 UTC) #2
Peter Kasting
LGTM
5 years, 6 months ago (2015-06-11 23:06:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178203004/1
5 years, 6 months ago (2015-06-12 06:25:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 07:21:29 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 07:22:24 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2a4e23128433254f5bd6ff9d7260e365232dbd31
Cr-Commit-Position: refs/heads/master@{#334131}

Powered by Google App Engine
This is Rietveld 408576698