Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: cc/layer_tree_host_unittest_context.cc

Issue 11782026: ThreadedTest that a non-null OutputSurface that fails initialization immediately doesn't crash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layer_tree_host_unittest_context.cc
diff --git a/cc/layer_tree_host_unittest_context.cc b/cc/layer_tree_host_unittest_context.cc
index 4e93ca80967a2017ebbc375b149b7e8d89b882c4..71648398071c7cc5c54fd7422c3efd318176ea61 100644
--- a/cc/layer_tree_host_unittest_context.cc
+++ b/cc/layer_tree_host_unittest_context.cc
@@ -780,5 +780,40 @@ class LayerTreeHostContextTestDontUseLostResources :
SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostContextTestDontUseLostResources)
+class FakeWebGraphicsContext3DMakeCurrentFails :
+ public FakeWebGraphicsContext3D {
+ public:
+ virtual bool makeContextCurrent() OVERRIDE { return false; }
+};
+
+class LayerTreeHostContextTestFailsImmediately : public ThreadedTest {
+ public:
+ LayerTreeHostContextTestFailsImmediately()
+ : ThreadedTest() {
+ }
+
+ virtual void beginTest() OVERRIDE {
+ postSetNeedsCommitToMainThread();
+ }
+
+ virtual void didRecreateOutputSurface(bool succeeded) OVERRIDE {
+ EXPECT_FALSE(succeeded);
+ // If we make it this far without crashing, we pass!
+ endTest();
+ }
+
+ virtual void afterTest() OVERRIDE {
+ }
+
+ virtual scoped_ptr<OutputSurface> createOutputSurface() OVERRIDE {
+ scoped_ptr<WebGraphicsContext3D> context_3d(
+ new FakeWebGraphicsContext3DMakeCurrentFails);
danakj 2013/01/08 00:49:08 I think you could just create a FakeWebGraphicsCon
+ return FakeOutputSurface::Create3d(
+ context_3d.Pass()).PassAs<OutputSurface>();
+ }
+};
+
+SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostContextTestFailsImmediately);
+
} // namespace
} // namespace cc
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698