Remove unused methods from SpdyFrameBuilder.

net/spdy/spdy_frame_builder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_FRAME_BUILDER_H_
 #define NET_SPDY_SPDY_FRAME_BUILDER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/string_piece.h"
 #include "base/sys_byteorder.h"
 #include "net/base/net_export.h"
 #include "net/spdy/spdy_protocol.h"
 
 namespace net {
 
 // This class provides facilities for basic binary value packing and unpacking

[Ryan Sleevi, 2013/01/07 23:46:49]

Does this comment need to be updated, now that it no longer does unpacking?

[Ryan Hamilton, 2013/01/08 00:48:32]

Done.

 // into Spdy frames.
 //
 // The SpdyFrameBuilder supports appending primitive values (int, string, etc)
 // to a frame instance.  The SpdyFrameBuilder grows its internal memory buffer
 // dynamically to hold the sequence of primitive values.   The internal memory
 // buffer is exposed as the "data" of the SpdyFrameBuilder.
 class NET_EXPORT_PRIVATE SpdyFrameBuilder {
  public:
   ~SpdyFrameBuilder();
 
@@ skipping 50 matching lines @@
 
   // Write to a particular offset in the data buffer.
   bool WriteBytesToOffset(int offset, const void* data, uint32 data_len) {
     if (offset + data_len > length_)
       return false;
     char *ptr = buffer_ + offset;
     memcpy(ptr, data, data_len);
     return true;
   }
 
-  // Returns true if the given iterator could point to data with the given
-  // length. If there is no room for the given data before the end of the
-  // payload, returns false.
-  bool IteratorHasRoomFor(const void* iter, int len) const {
-    const char* end_of_region = reinterpret_cast<const char*>(iter) + len;
-    if (len < 0 ||
-        iter < buffer_ ||
-        iter > end_of_payload() ||
-        iter > end_of_region ||
-        end_of_region > end_of_payload())
-      return false;
-
-    // Watch out for overflow in pointer calculation, which wraps.
-    return (iter <= end_of_region) && (end_of_region <= end_of_payload());
-  }
-
  protected:
-  size_t capacity() const {
-    return capacity_;
-  }
-
   const char* end_of_payload() const { return buffer_ + length_; }
 
   // Completes the write operation by padding the data with NULL bytes until it
   // is padded. Should be paired with BeginWrite, but it does not necessarily
   // have to be called after the data is written.
   void EndWrite(char* dest, int length);
 
-  // Moves the iterator by the given number of bytes.
-  static void UpdateIter(void** iter, int bytes) {
-    *iter = static_cast<char*>(*iter) + bytes;
-  }
-
  private:
   // Returns the location that the data should be written at, or NULL if there
   // is not enough room. Call EndWrite with the returned offset and the given
   // length to pad out for the next write.
   char* BeginWrite(size_t length);
 
   char* buffer_;

[Ryan Sleevi, 2013/01/07 23:46:49]

Could also do scoped_ptr<char[]>

(unique_ptr<> in C+11/internal)

Minor though

[Ryan Hamilton, 2013/01/08 00:48:32]

Done.

   size_t capacity_;  // Allocation size of payload (or -1 if buffer is const).
   size_t length_;    // current length of the buffer
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_FRAME_BUILDER_H_