Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 11782008: Revert 175233 because Linux ASAN builder cannot compile it. (Closed)

Created:
7 years, 11 months ago by alexeypa (please no reviews)
Modified:
7 years, 11 months ago
Reviewers:
elijahtaylor1
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, erikwright+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Revert 175233 because Linux ASAN builder cannot compile it. http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Builder&number=15352 > Add trace event Pepper API > > This facilitates adding trace data to chrome://tracing from plugins. > > - broke out trace_event.h into trace_event.h/trace_event_internal.h > for easier transplanting to plugin code by eliminating dependence on base/. > - inlined trace_event.cc methods (4 total) so the trace_event_internal > implementation is contained in headers. > - added new PPB_TraceEvent_Dev interface (implemented entirely on the plugin side) > > BUG=none > TEST=base unittests, manual for plugin testing > > > Review URL: https://chromiumcodereview.appspot.com/11464005 TBR=elijahtaylor@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+878 lines, -1162 lines) Patch
M base/base.gypi View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event.h View 2 chunks +876 lines, -14 lines 0 comments Download
A + base/debug/trace_event.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D base/debug/trace_event_internal.h View 1 chunk +0 lines, -897 lines 0 comments Download
D ppapi/api/dev/ppb_trace_event_dev.idl View 1 chunk +0 lines, -50 lines 0 comments Download
D ppapi/c/dev/ppb_trace_event_dev.h View 1 chunk +0 lines, -68 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 6 chunks +0 lines, -13 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppb_instance_shared.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D ppapi/shared_impl/ppb_trace_event_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ppapi/shared_impl/ppb_trace_event_impl.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 3 chunks +2 lines, -3 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
alexeypa (please no reviews)
7 years, 11 months ago (2013-01-04 23:48:21 UTC) #1
elijahtaylor1
7 years, 11 months ago (2013-01-04 23:51:55 UTC) #2
Message was sent while issue was closed.
On 2013/01/04 23:48:21, alexeypa wrote:

LGTM, sorry about this one and not being on IRC, thanks

Powered by Google App Engine
This is Rietveld 408576698