base/file_util.cc - Issue 11782005: Don't allow path traversal paths on the base file helpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/file_util.cc

Issue 11782005: Don't allow path traversal paths on the base file helpers (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/file_util.cc

===================================================================

--- base/file_util.cc (revision 175095)

+++ base/file_util.cc (working copy)

@@ -152,6 +152,8 @@

}

bool ReadFileToString(const FilePath& path, std::string* contents) {

+ if (path.ReferencesParent())

brettw 2013/01/07 20:50:26 Maybe this warrants a mention in the header as wel

+ return false;

FILE* file = OpenFile(path, "rb");

if (!file) {

return false;

« no previous file with comments | « no previous file | base/platform_file.h » ('j') | base/platform_file.h » ('J')