Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Issue 1178193004: Add ToObject call in Array.prototype.sort (Closed)

Created:
5 years, 6 months ago by dehrenberg
Modified:
5 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add ToObject call in Array.prototype.sort The spec says ToObject is called on the receiver, and this is observable if you call sort on a primitive. This patch trivially adds the call and a test. BUG=v8:4125 R=adamk LOG=Y Committed: https://crrev.com/cbf9137707edcc6c4e09b2a680667a52c3226621 Cr-Commit-Position: refs/heads/master@{#28972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/array.js View 1 chunk +3 lines, -2 lines 0 comments Download
M test/mjsunit/array-sort.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dan Ehrenberg
5 years, 6 months ago (2015-06-11 20:29:07 UTC) #2
adamk
lgtm At some point we should decide when to use TO_OBJECT_INLINE vs $toObject, but this ...
5 years, 6 months ago (2015-06-11 20:30:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178193004/1
5 years, 6 months ago (2015-06-11 20:31:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178193004/1
5 years, 6 months ago (2015-06-11 20:32:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 21:43:14 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 21:43:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbf9137707edcc6c4e09b2a680667a52c3226621
Cr-Commit-Position: refs/heads/master@{#28972}

Powered by Google App Engine
This is Rietveld 408576698