Issue 1178173004: Add missing dependency to the build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178173004: Add missing dependency to the build (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add missing dependency to the build We've had a number of reports of a missing dependency in the build. I managed to reproduce the issue locally today and this patch fixed the issue I was seeing. Hopefully it fixes the issues other folks were seeing too. The problem was that the C++ code we generate from IDL files depended on various event classes in core, which in turn depended on the generated event names files. This CL ensures that the event names files are created before we try to build the C++ code generated from the IDL files. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5ad488cb92a4b987889aeb21cab6aab86dd6c097

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	sky/engine/bindings/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 6 months ago (2015-06-13 16:47:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5ad488cb92a4b987889aeb21cab6aab86dd6c097 (presubmit successful).

Expand Messages | Collapse Messages