Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1178153004: [turbofan] Fix throwing conversion inserted by JSTypedLowering. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix throwing conversion inserted by JSTypedLowering. This fixes the graph wiring of implicit JSToNumber nodes inserted by JSTypedLowering, to be correctly hooked into a surrounding exceptional continuation. R=bmeurer@chromium.org TEST=mjsunit/compiler/try-binop,test262 Committed: https://crrev.com/063079976c2c897de6c470fea415cdd458645a3a Cr-Commit-Position: refs/heads/master@{#28975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -92 lines) Patch
M src/compiler/js-typed-lowering.cc View 3 chunks +73 lines, -19 lines 0 comments Download
M src/compiler/node-properties.cc View 2 chunks +5 lines, -4 lines 0 comments Download
A test/mjsunit/compiler/try-binop.js View 1 chunk +45 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -5 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -32 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-11 15:32:06 UTC) #1
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-12 04:40:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178153004/1
5 years, 6 months ago (2015-06-12 04:40:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 04:42:10 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 04:42:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/063079976c2c897de6c470fea415cdd458645a3a
Cr-Commit-Position: refs/heads/master@{#28975}

Powered by Google App Engine
This is Rietveld 408576698