Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 117813003: Add BUILD.gn file for components's translate_common target. (Closed)

Created:
7 years ago by tfarina
Modified:
7 years ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Add BUILD.gn file for components's translate_common target. BUG=None TEST=gn, ninja -C out/Default translate_common R=brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M tools/gn/secondary/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/secondary/components/navigation_metrics/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/components/startup_metric_utils/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A tools/gn/secondary/components/translate/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
7 years ago (2013-12-18 01:30:49 UTC) #1
tfarina
Ping??
7 years ago (2013-12-19 20:35:41 UTC) #2
brettw
lgtm
7 years ago (2013-12-19 21:06:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/117813003/1
7 years ago (2013-12-20 15:45:26 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-20 17:05:01 UTC) #5
Message was sent while issue was closed.
Change committed as 242112

Powered by Google App Engine
This is Rietveld 408576698