Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1178123004: Fix for dashing shader on Mali: use highp where necessary. (Closed)

Created:
5 years, 6 months ago by Stephen White
Modified:
5 years, 6 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix for dashing shader on Mali: use highp where necessary. The varyings used to compute rect coverage need to be high precision, since they're offset by the frag coord. R=egdaniel BUG=skia:3935 Committed: https://skia.googlesource.com/skia/+/1422ec86f2e97323f876a267bc5dae3fbf1eac96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Stephen White
Greg: PTAL. Thanks!
5 years, 6 months ago (2015-06-11 16:02:29 UTC) #1
egdaniel
lgtm
5 years, 6 months ago (2015-06-11 17:46:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178123004/1
5 years, 6 months ago (2015-06-11 18:45:14 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 18:51:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1422ec86f2e97323f876a267bc5dae3fbf1eac96

Powered by Google App Engine
This is Rietveld 408576698