Use LookupIterator in GetOldValue

Use LookupIterator in GetOldValue

BUG=v8:4137
LOG=n

Committed: https://crrev.com/7b5264475c7c3eb3325df867dae4748fd80ae733
Cr-Commit-Position: refs/heads/master@{#28973}

[Toon Verwaest, 2015-06-11 12:32:21]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2015-06-11 12:32:21]

PTAL

[Jakob Kummerow, 2015-06-11 14:35:24]

lgtm

https://codereview.chromium.org/1178123003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1178123003/diff/1/src/objects.cc#newcode11853
src/objects.cc:11853: CHECK(JSReceiver::GetPropertyAttributes(&it).IsJust());
Can this be a DCHECK?

[Toon Verwaest, 2015-06-11 14:46:26]

https://codereview.chromium.org/1178123003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1178123003/diff/1/src/objects.cc#newcode11853
src/objects.cc:11853: CHECK(JSReceiver::GetPropertyAttributes(&it).IsJust());
On 2015/06/11 14:35:24, Jakob wrote:
> Can this be a DCHECK?

No, in that case it wouldn't run in release mode.
Alternatively I can make a local variable which I USE and DCHECK(v.IsJust());
This seems a bit cleaner and in sync with other places...

[Toon Verwaest, 2015-06-11 16:31:05]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-06-11 16:31:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1178123003/1

[commit-bot: I haz the power, 2015-06-11 16:35:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 16:35:33]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Toon Verwaest, 2015-06-11 21:42:38]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-06-11 21:42:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1178123003/1

[commit-bot: I haz the power, 2015-06-11 23:02:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-11 23:02:51]

Patchset 1 (id:??) landed as
https://crrev.com/7b5264475c7c3eb3325df867dae4748fd80ae733
Cr-Commit-Position: refs/heads/master@{#28973}