Correctly send the 'HTTPS' header for top-level navigations.
We don't have an active Document during top-level navigation, which I
didn't account for when adding the 'HTTPS' header. This patch adjusts
the expectations to match reality.
BUG=495991
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197016
4 years, 10 months ago
(2015-06-11 10:53:49 UTC)
#2
Mind taking a look at this, Jochen?
jochen (gone - plz use gerrit)
is it possible to test this?
4 years, 10 months ago
(2015-06-11 11:26:33 UTC)
#3
is it possible to test this?
Mike West
On 2015/06/11 at 11:26:33, jochen wrote: > is it possible to test this? Via unit ...
4 years, 10 months ago
(2015-06-11 11:29:31 UTC)
#4
On 2015/06/11 at 11:26:33, jochen wrote:
> is it possible to test this?
Via unit tests, yes, and we're doing so!
Via layout tests, maybe! We can't test most of this via layout tests because of
ports (`upgrade` doesn't deal well with :8000 and :8443). But now that I think
about it, this behavior shouldn't rely on that. Let me poke at it.
Mike West
On 2015/06/11 at 11:29:31, Mike West wrote: > On 2015/06/11 at 11:26:33, jochen wrote: > ...
4 years, 10 months ago
(2015-06-11 12:17:15 UTC)
#5
On 2015/06/11 at 11:29:31, Mike West wrote:
> On 2015/06/11 at 11:26:33, jochen wrote:
> > is it possible to test this?
>
> Via unit tests, yes, and we're doing so!
>
> Via layout tests, maybe! We can't test most of this via layout tests because
of ports (`upgrade` doesn't deal well with :8000 and :8443). But now that I
think about it, this behavior shouldn't rely on that. Let me poke at it.
Take another look?
Mike West
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
4 years, 10 months ago
(2015-06-12 03:54:21 UTC)
#6
Issue 1178093002: Correctly send the 'HTTPS' header for top-level navigations.
(Closed)
Created 4 years, 10 months ago by Mike West
Modified 4 years, 10 months ago
Reviewers: jochen (gone - plz use gerrit)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 0