Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1178083003: Revert of [heap] Unify the immortal immovable root detection mechanism. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Unify the immortal immovable root detection mechanism. (patchset #3 id:40001 of https://codereview.chromium.org/1178853002/) Reason for revert: [Sheriff] tsan failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4240 Original issue's description: > [heap] Unify the immortal immovable root detection mechanism. > > Uniformly use the Heap::GetRootListIndex() and > Heap::RootIsImmortalImmovable() methods to detect immortal immovable > roots in the optimizing compilers. > > R=jarin@chromium.org > > Committed: https://crrev.com/84e83da99a72edc169367bf88588b1a2f10c2e08 > Cr-Commit-Position: refs/heads/master@{#28933} TBR=jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/af83ab69b9568c005b5feca8b272a082b7da7f1d Cr-Commit-Position: refs/heads/master@{#28934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -93 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/heap/heap.h View 4 chunks +58 lines, -5 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +17 lines, -72 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +14 lines, -3 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/unique.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [heap] Unify the immortal immovable root detection mechanism.
5 years, 6 months ago (2015-06-11 10:49:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178083003/1
5 years, 6 months ago (2015-06-11 10:49:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 10:49:39 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 10:49:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af83ab69b9568c005b5feca8b272a082b7da7f1d
Cr-Commit-Position: refs/heads/master@{#28934}

Powered by Google App Engine
This is Rietveld 408576698