Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1178083002: Use LookupIterator for elements in GetAccessor (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use LookupIterator for elements in GetAccessor BUG=v8:4137 LOG=n Committed: https://crrev.com/2cdfd4daa9d11c5ee9160e644f2e79c74bca31d0 Cr-Commit-Position: refs/heads/master@{#28962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -54 lines) Patch
M src/objects.cc View 1 chunk +29 lines, -54 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
PTAL
5 years, 6 months ago (2015-06-11 10:44:52 UTC) #2
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-11 12:05:35 UTC) #4
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-11 13:34:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178083002/1
5 years, 6 months ago (2015-06-11 16:11:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 20:08:16 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 20:08:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cdfd4daa9d11c5ee9160e644f2e79c74bca31d0
Cr-Commit-Position: refs/heads/master@{#28962}

Powered by Google App Engine
This is Rietveld 408576698