Updated error translation logic.

Updated error translation logic.

This CL changes several aspects of our error translation code:
- Moves the actual translation process to |-loadErrorInNativeView:|.
  This allows the logic in |-handleLoadError:inMainFrame:| to correctly
  differentiate between webview-generated errors and errors originating
  from the net stack.
- Changes |NetErrorFromError()| to translate the ultimate underlying
  error rather than the top-level error, and appends the translated
  error to the end of the passed-in error's underlying error chain.
- Created |GetUltimateUnderlyingErrorForError()|, which iterates through
  the underlying error chain to find the original error.

BUG=492434, 496972, 496115, 473888
Committed: https://crrev.com/d70e5c4bd55edf8c901b11b6f1e0aa8f1bacdde5
Cr-Commit-Position: refs/heads/master@{#337475}

[kkhorimoto, 2015-06-19 00:26:15]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, stuartmorgan@chromium.org

[Eugene But (OOO till 7-30), 2015-06-19 00:52:02]

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
File ios/web/public/web_state/error_translation_util.h (right):

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
ios/web/public/web_state/error_translation_util.h:14: NSError*
GetUltimateUnderlyingErrorForError(NSError* error);
NIT: How about Final instead of Ultimate?

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
ios/web/public/web_state/error_translation_util.h:14: NSError*
GetUltimateUnderlyingErrorForError(NSError* error);
NIT: s/For/From

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
ios/web/public/web_state/error_translation_util.h:20: NSError*
NetErrorFromError(NSError* error);
I believe this method should not be a part of web's public interface. Embedder
should not care about iOS specific error codes. WDYT?

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
File ios/web/public/web_state/error_translation_util.mm (right):

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
ios/web/public/web_state/error_translation_util.mm:141: for (NSInteger idx =
error_chain.count - 1; idx >= 0; --idx) {
Optional NIT: Consider [error_chain
enumerateObjectsWithOptions:NSEnumerationReverse usingBlock:^(){

}

This is safer API, but formatting may be ugly because of the block.

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
ios/web/public/web_state/error_translation_util.mm:145: [user_info
setObject:current_error forKey:NSUnderlyingErrorKey];
user_info[NSUnderlyingErrorKey] = current_error;

https://codereview.chromium.org/1178063007/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1178063007/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2939: // reattempting this load.
Please make sure that LoadState will still be PAGE_LOADED and not PAGE_LOADING.

[kkhorimoto, 2015-06-23 20:33:57]

kkhorimoto@chromium.org changed reviewers:
+ danakj@chromium.org

[kkhorimoto, 2015-06-23 20:33:59]

Addressed Eugene's comments.

+ danakj for base/

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
File ios/web/public/web_state/error_translation_util.h (right):

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
ios/web/public/web_state/error_translation_util.h:14: NSError*
GetUltimateUnderlyingErrorForError(NSError* error);
On 2015/06/19 00:52:01, eugenebut wrote:
> NIT: s/For/From

Done.

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
ios/web/public/web_state/error_translation_util.h:20: NSError*
NetErrorFromError(NSError* error);
On 2015/06/19 00:52:01, eugenebut wrote:
> I believe this method should not be a part of web's public interface. Embedder
> should not care about iOS specific error codes. WDYT?

The main reason I moved these files to the public directory is so that we can
use GetFinalUnderlyingErrorFromError from outside of web/.  I agree, though,
that this isn't something that we necessarily need to be public.  I'll move this
back into the non-public directory and introduce a more general NSError utility
file for GetFinalUnderlyingErrorFromError.

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
File ios/web/public/web_state/error_translation_util.mm (right):

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
ios/web/public/web_state/error_translation_util.mm:141: for (NSInteger idx =
error_chain.count - 1; idx >= 0; --idx) {
On 2015/06/19 00:52:01, eugenebut wrote:
> Optional NIT: Consider [error_chain
> enumerateObjectsWithOptions:NSEnumerationReverse usingBlock:^(){
> 
> }
> 
> This is safer API, but formatting may be ugly because of the block.

I did that initially, but it actually made memory management difficult since the
block is run in an autorelease pool.  Doing a manual iteration like this saves
us from writing extra memory management code and formats better than the
block-based approach.

https://codereview.chromium.org/1178063007/diff/1/ios/web/public/web_state/er...
ios/web/public/web_state/error_translation_util.mm:145: [user_info
setObject:current_error forKey:NSUnderlyingErrorKey];
On 2015/06/19 00:52:01, eugenebut wrote:
> user_info[NSUnderlyingErrorKey] = current_error;

Bracket notation doesn't work for scoped_nsobjects.

https://codereview.chromium.org/1178063007/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1178063007/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2939: // reattempting this load.
On 2015/06/19 00:52:01, eugenebut wrote:
> Please make sure that LoadState will still be PAGE_LOADED and not
PAGE_LOADING.

Done, although the fix is somewhat speculative.  There's no documentation for
WKWebView ensuring that navigation failures are automatically retried while
provisional load errors are not; the solution I created is based on what I've
observed.

History navigations to m.facebook.com/GoogleMaps generates a navigation error
and is retried, and scenarioNonRecoverableSSLError and
scenarioRecoverableSSLError both generate provisional load errors that are not
automatically retried.

[danakj, 2015-06-23 20:55:17]

On 2015/06/23 20:33:59, kkhorimoto_ wrote:
> Addressed Eugene's comments.
> 
> + danakj for base/

Why does this need to move to base/ ?

[kkhorimoto, 2015-06-23 21:00:16]

On 2015/06/23 20:55:17, danakj wrote:
> On 2015/06/23 20:33:59, kkhorimoto_ wrote:
> > Addressed Eugene's comments.
> > 
> > + danakj for base/
> 
> Why does this need to move to base/ ?

The NSError utility functions need to be accessible from both web/ and chrome/
code, and the functions there aren't conceptually linked with web/
functionality.

[Eugene But (OOO till 7-30), 2015-06-23 21:27:14]

https://codereview.chromium.org/1178063007/diff/20001/base/base.gypi
File base/base.gypi (right):

https://codereview.chromium.org/1178063007/diff/20001/base/base.gypi#newcode251
base/base.gypi:251: 'ios/nserror_util.h',
ns_error_util (see ui_web_view for example)

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.h
File base/ios/nserror_util.h (right):

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.h...
base/ios/nserror_util.h:11: namespace nserror_util {
I think the namespace for this should be ios. I know about inconsistency in
namespace usage (f.e. base::device_util)

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/error...
File ios/web/web_state/error_translation_util.h (right):

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/error...
ios/web/web_state/error_translation_util.h:14: // its ultimate underlying error.
 If there is no viable translation, the
s/ultimate/final

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_wk_web_view_web_controller.mm (right):

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_wk_web_view_web_controller.mm:67: [userInfo
setValue:@(source) forKey:kWKWebViewErrorSourceKey];
s/setValue/setObject

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_wk_web_view_web_controller.mm:446: // Don't abort
NSURLErrorCancelled errors originating from navigation, as the
Early return here:

if (isAppSpecificURL)
  return NO;

[danakj, 2015-06-24 16:32:58]

danakj@chromium.org changed reviewers:
+ thakis@chromium.org

[danakj, 2015-06-24 16:32:58]

Hm, I don't really know anything about obj-c so it's tough for me to make head
or tail of this. I'm going to add Nico as a reviewer instead.

[Nico, 2015-06-24 18:55:17]

On 2015/06/24 16:32:58, danakj wrote:
> Hm, I don't really know anything about obj-c so it's tough for me to make head
> or tail of this. I'm going to add Nico as a reviewer instead.

base/ios/OWNERS (i.e. stuartmorgan) should probably look at this. The gypi
change looks fine to me. I don't know if you need to change any .gn files.

[stuartmorgan, 2015-06-24 19:13:09]

I suspect I'm missing something obvious here but... when would we have chained
underlying errors? I thought it was just to hold the original vs translated
error, but it doesn't seem like we'd ever want to re-translate an error.

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.h
File base/ios/nserror_util.h (right):

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.h...
base/ios/nserror_util.h:11: namespace nserror_util {
On 2015/06/23 21:27:14, eugenebut wrote:
> I think the namespace for this should be ios. I know about inconsistency in
> namespace usage (f.e. base::device_util)

Yes, either base::ios or base::ios::nserror_util

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.mm
File base/ios/nserror_util.mm (right):

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.m...
base/ios/nserror_util.mm:7: #import <Foundation/Foundation.h>
Blank line after this.

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.m...
base/ios/nserror_util.mm:34: DCHECK(original_error && underlying_error);
Separate the DCHECKs, so that if one fails it's immediately obvious which.

[kkhorimoto, 2015-06-24 20:01:42]

I've seen errors in CRWWebController's |-handleLoadError:isMainFrame:| that have
underlying errors that are not from the net stack, namely time out errors. 
Also, the error translation code only attempts to translate errors that are of
the NSURLError domain, so the translation will only occur once.  The
introduction of the chaining code is so that none of the info from nested
underlying errors is lost.

https://codereview.chromium.org/1178063007/diff/20001/base/base.gypi
File base/base.gypi (right):

https://codereview.chromium.org/1178063007/diff/20001/base/base.gypi#newcode251
base/base.gypi:251: 'ios/nserror_util.h',
On 2015/06/23 21:27:14, eugenebut wrote:
> ns_error_util (see ui_web_view for example)

Done.

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.h
File base/ios/nserror_util.h (right):

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.h...
base/ios/nserror_util.h:11: namespace nserror_util {
On 2015/06/23 21:27:14, eugenebut wrote:
> I think the namespace for this should be ios. I know about inconsistency in
> namespace usage (f.e. base::device_util)

Done.

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.mm
File base/ios/nserror_util.mm (right):

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.m...
base/ios/nserror_util.mm:7: #import <Foundation/Foundation.h>
On 2015/06/24 19:13:09, stuartmorgan wrote:
> Blank line after this.

Done.

https://codereview.chromium.org/1178063007/diff/20001/base/ios/nserror_util.m...
base/ios/nserror_util.mm:34: DCHECK(original_error && underlying_error);
On 2015/06/24 19:13:09, stuartmorgan wrote:
> Separate the DCHECKs, so that if one fails it's immediately obvious which.

Done.

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/error...
File ios/web/web_state/error_translation_util.h (right):

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/error...
ios/web/web_state/error_translation_util.h:14: // its ultimate underlying error.
 If there is no viable translation, the
On 2015/06/23 21:27:14, eugenebut wrote:
> s/ultimate/final

Done.

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_wk_web_view_web_controller.mm (right):

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_wk_web_view_web_controller.mm:67: [userInfo
setValue:@(source) forKey:kWKWebViewErrorSourceKey];
On 2015/06/23 21:27:14, eugenebut wrote:
> s/setValue/setObject

Done.

https://codereview.chromium.org/1178063007/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_wk_web_view_web_controller.mm:446: // Don't abort
NSURLErrorCancelled errors originating from navigation, as the
On 2015/06/23 21:27:14, eugenebut wrote:
> Early return here:
> 
> if (isAppSpecificURL)
>   return NO;

Done.

[Eugene But (OOO till 7-30), 2015-06-24 20:30:46]

lgtm

[stuartmorgan, 2015-06-24 21:30:48]

Makes sense now; LGTM with nits.

https://codereview.chromium.org/1178063007/diff/40001/base/ios/ns_error_util.mm
File base/ios/ns_error_util.mm (right):

https://codereview.chromium.org/1178063007/diff/40001/base/ios/ns_error_util....
base/ios/ns_error_util.mm:16: // Iterates through |error|'s underlying errors
and returns them in an array.
Since this actually returns |error| as well, the name/description seems
confusing. How about GetFullErrorChainForError or similar?

https://codereview.chromium.org/1178063007/diff/40001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1178063007/diff/40001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:2936: // chrome network stack. 
Aborting the load in this case.
Chrome

s/Aborting/Abort/

[kkhorimoto, 2015-06-24 22:17:59]

https://codereview.chromium.org/1178063007/diff/40001/base/ios/ns_error_util.mm
File base/ios/ns_error_util.mm (right):

https://codereview.chromium.org/1178063007/diff/40001/base/ios/ns_error_util....
base/ios/ns_error_util.mm:16: // Iterates through |error|'s underlying errors
and returns them in an array.
On 2015/06/24 21:30:48, stuartmorgan wrote:
> Since this actually returns |error| as well, the name/description seems
> confusing. How about GetFullErrorChainForError or similar?

Done.

https://codereview.chromium.org/1178063007/diff/40001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1178063007/diff/40001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:2936: // chrome network stack. 
Aborting the load in this case.
On 2015/06/24 21:30:48, stuartmorgan wrote:
> Chrome
> 
> s/Aborting/Abort/

Done.

[kkhorimoto, 2015-06-24 22:18:14]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2015-06-24 22:18:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
stuartmorgan@chromium.org, eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1178063007/#ps60001
(title: "stuart's comments")

[commit-bot: I haz the power, 2015-06-24 22:19:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1178063007/60001

[commit-bot: I haz the power, 2015-06-24 22:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-24 22:31:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2015-06-25 03:43:55]

base.gypi lgtm

[Nico, 2015-06-25 03:44:10]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-06-25 03:44:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1178063007/60001

[Nico, 2015-06-25 03:45:08]

FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/ios/web/web_state/ui/ios_web.crw_ui_web_view_web_controller.i386.o.d
-DV8_DEPRECATION_WARNINGS -DDISABLE_NACL -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=239765-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_CONFIGURATION_POLICY
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA
-DCLD_VERSION=2 -DDISABLE_FTP_SUPPORT=1 -DV8_USE_EXTERNAL_STARTUP_DATA
-DMOJO_USE_SYSTEM_IMPL -DUSE_SYSTEM_LIBXML -DSK_SUPPORT_GPU=0
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0
-DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DUSE_LIBPCI=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../.. -I../../third_party/khronos
-I../../gpu -I../../skia/config
-I/Applications/Xcode6.3.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.3.sdk/usr/include/libxml2
-I../../third_party/WebKit -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../skia/ext -I../../third_party/mojo/src -Igen/third_party/mojo/src
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-Igen/ui/resources -isysroot
/Applications/Xcode6.3.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.3.sdk
-O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof
-mios-simulator-version-min=7.0 -arch i386 -Wall -Wendif-labels -Wextra
-Wno-unused-parameter -Wno-missing-field-initializers
-Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts
-Wno-unneeded-internal-declaration -Wno-covered-switch-default
-Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register
-Wno-inconsistent-missing-override -std=c++11 -stdlib=libc++ -fno-rtti
-fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang
-load -Xclang
/b/build/slave/ios_dbg_simulator_ninja/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
-fstack-protector-all -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare -Wobjc-missing-property-synthesis
-fobjc-call-cxx-cdtors  -c
../../ios/web/web_state/ui/crw_ui_web_view_web_controller.mm -o
obj/ios/web/web_state/ui/ios_web.crw_ui_web_view_web_controller.i386.o
../../ios/web/web_state/ui/crw_ui_web_view_web_controller.mm:815:54:error: no
member named 'kErrorDomain' in namespace 'net'
  NSString* netDomain = base::SysUTF8ToNSString(net::kErrorDomain);
                                                ~~~~~^
1 error generated.
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/ios/web/web_state/ui/ios_web.crw_ui_web_view_web_controller.x86_64.o.d
-DV8_DEPRECATION_WARNINGS -DDISABLE_NACL -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=239765-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_CONFIGURATION_POLICY
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA
-DCLD_VERSION=2 -DDISABLE_FTP_SUPPORT=1 -DV8_USE_EXTERNAL_STARTUP_DATA
-DMOJO_USE_SYSTEM_IMPL -DUSE_SYSTEM_LIBXML -DSK_SUPPORT_GPU=0
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0
-DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DUSE_LIBPCI=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../.. -I../../third_party/khronos
-I../../gpu -I../../skia/config
-I/Applications/Xcode6.3.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.3.sdk/usr/include/libxml2
-I../../third_party/WebKit -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../skia/ext -I../../third_party/mojo/src -Igen/third_party/mojo/src
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-Igen/ui/resources -isysroot
/Applications/Xcode6.3.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.3.sdk
-O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof
-mios-simulator-version-min=7.0 -arch x86_64 -Wall -Wendif-labels -Wextra
-Wno-unused-parameter -Wno-missing-field-initializers
-Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts
-Wno-unneeded-internal-declaration -Wno-covered-switch-default
-Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register
-Wno-inconsistent-missing-override -std=c++11 -stdlib=libc++ -fno-rtti
-fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang
-load -Xclang
/b/build/slave/ios_dbg_simulator_ninja/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
-fstack-protector-all -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare -Wobjc-missing-property-synthesis
-fobjc-call-cxx-cdtors  -c
../../ios/web/web_state/ui/crw_ui_web_view_web_controller.mm -o
obj/ios/web/web_state/ui/ios_web.crw_ui_web_view_web_controller.x86_64.o
../../ios/web/web_state/ui/crw_ui_web_view_web_controller.mm:815:54:error: no
member named 'kErrorDomain' in namespace 'net'
  NSString* netDomain = base::SysUTF8ToNSString(net::kErrorDomain);
                                                ~~~~~^
1 error generated.
ninja: build stopped: subcommand failed.

That looks real though. (Also, "crw_ui_web_view_web" ಠ_ಠ)

[kkhorimoto, 2015-06-25 03:47:23]

The CQ bit was unchecked by kkhorimoto@chromium.org

[kkhorimoto, 2015-07-06 20:00:00]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2015-07-06 20:00:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
stuartmorgan@chromium.org, thakis@chromium.org, eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1178063007/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-07-06 20:01:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1178063007/80001

[commit-bot: I haz the power, 2015-07-06 21:22:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-06 21:23:09]

Patchset 5 (id:??) landed as
https://crrev.com/d70e5c4bd55edf8c901b11b6f1e0aa8f1bacdde5
Cr-Commit-Position: refs/heads/master@{#337475}