Issue 1178063005: DevTools: editor should not loose scroll position when displaying inline values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178063005: DevTools: editor should not loose scroll position when displaying inline values (Closed)

Created:
4 years, 10 months ago by lushnikov

Modified:
4 years, 10 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: editor should not loose scroll position when displaying inline values The bug happens due to the following reasons: a) CodeMirror requires manual scroll restoring after it is attached to DOM. It is usually done via "refresh" method call, but we optimize this and restore scroll position via custom super-fast logic, written in CodeMirrorTExtEditor.onResize. b) if a codeMirror.operation is called on unitialized CodeMirror instance, then scroll position is lost. This patch post-pones inline value processing until textEditor is initialized. BUG=499889 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197273

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	Source/devtools/front_end/sources/JavaScriptSourceFrame.js	View		1 chunk	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178063005/1

4 years, 10 months ago (2015-06-17 15:39:33 UTC) #4

commit-bot: I haz the power

4 years, 10 months ago (2015-06-17 19:26:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197273

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages