Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 1178043004: [3b] Load data via WebDataConsumerHandle in FetchManager::Loader (Closed)

Created:
4 years, 10 months ago by hiroshige
Modified:
4 years, 10 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Load data via WebDataConsumerHandle in FetchManager::Loader This CL loads data in Fetch API via stream by setting setUseStreamOnResponse(). FetchManager::Loader::Canceller is removed because cancellation from WebDataConsumerHandle is notified via didFail() by https://codereview.chromium.org/1186053004/. BUG=480746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197728

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -59 lines) Patch
M Source/modules/fetch/FetchManager.cpp View 1 2 11 chunks +5 lines, -59 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
hiroshige
PTAL.
4 years, 10 months ago (2015-06-18 05:53:11 UTC) #2
yhirano
lgtm
4 years, 10 months ago (2015-06-19 06:36:54 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178043004/40001
4 years, 10 months ago (2015-06-23 10:52:40 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60268)
4 years, 10 months ago (2015-06-23 12:08:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178043004/40001
4 years, 10 months ago (2015-06-24 09:35:48 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 10:22:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197728

Powered by Google App Engine
This is Rietveld 408576698