Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1178043002: Update ServiceWorker event handled status histogram (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index ff185072741e0c3924c982e8da48573ee9a068c4..17889607937cf124fc2870e01a870929df3a506b 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -396,10 +396,12 @@ class ServiceWorkerVersion::Metrics {
public:
Metrics() {}
~Metrics() {
- ServiceWorkerMetrics::RecordEventStatus(fired_events, handled_events);
+ ServiceWorkerMetrics::RecordPerWorkerEventHandledStatus(fired_events,
+ handled_events);
}
- void RecordEventStatus(bool handled) {
+ void RecordEventHandledStatus(bool handled) {
+ ServiceWorkerMetrics::RecordEventHandledStatus(handled);
++fired_events;
if (handled)
++handled_events;
@@ -1329,7 +1331,7 @@ void ServiceWorkerVersion::OnFetchEventFinished(
// TODO(kinuko): Record other event statuses too.
const bool handled = (result == SERVICE_WORKER_FETCH_EVENT_RESULT_RESPONSE);
- metrics_->RecordEventStatus(handled);
+ metrics_->RecordEventHandledStatus(handled);
scoped_refptr<ServiceWorkerVersion> protect(this);
callback->Run(SERVICE_WORKER_OK, result, response);

Powered by Google App Engine
This is Rietveld 408576698