Update ServiceWorker event handled status histogram

content/browser/service_worker/service_worker_metrics.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_metrics.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/user_metrics_action.h"
+#include "base/strings/string_util.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/common/content_client.h"
 
 namespace content {
 
 namespace {
 
 void RecordURLMetricOnUI(const GURL& url) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   GetContentClient()->browser()->RecordURLMetric(
       "ServiceWorker.ControlledPageUrl", url);
 }
 
+bool ShouldExcludeForHistogram(const GURL& scope) {
+  // Exclude NTP scope from UMA for now.

[falken, 2015/07/03 04:45:00]

Comment should also say why, as the CL description does.

[kinuko, 2015/07/05 09:19:04]

Done.

+  // TOOD(kinuko): This should be temporary, revisit this once we have
+  // better idea about what should be excluded in the UMA.
+  // (UIThreadSearchTermsData::GoogleBaseURLValue() returns the google base
+  // URL, but not available in content layer)
+  const char google_like_scope_prefix[] = "https://www.google.";
+  return base::StartsWith(scope.spec(), google_like_scope_prefix,
+                          base::CompareCase::INSENSITIVE_ASCII);
+}
+
+enum EventHandledRatioType {
+  EVENT_HANDLED_NONE,
+  EVENT_HANDLED_SOME,
+  EVENT_HANDLED_ALL,
+  NUM_EVENT_HANDLED_RATIO_TYPE,
+};
+
 }  // namespace
 
 void ServiceWorkerMetrics::CountInitDiskCacheResult(bool result) {
   UMA_HISTOGRAM_BOOLEAN("ServiceWorker.DiskCache.InitResult", result);
 }
 
 void ServiceWorkerMetrics::CountReadResponseResult(
     ServiceWorkerMetrics::ReadResponseResult result) {
   UMA_HISTOGRAM_ENUMERATION("ServiceWorker.DiskCache.ReadResponseResult",
                             result, NUM_READ_RESPONSE_RESULT_TYPES);
@@ skipping 81 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("ServiceWorker.ActivateEventStatus", status,
                             SERVICE_WORKER_ERROR_MAX_VALUE);
 }
 
 void ServiceWorkerMetrics::RecordInstallEventStatus(
     ServiceWorkerStatusCode status) {
   UMA_HISTOGRAM_ENUMERATION("ServiceWorker.InstallEventStatus", status,
                             SERVICE_WORKER_ERROR_MAX_VALUE);
 }
 
-void ServiceWorkerMetrics::RecordEventStatus(size_t fired_events,
-                                             size_t handled_events) {
-  if (!fired_events)
+void ServiceWorkerMetrics::RecordEventHandledRatio(const GURL& scope,
+                                                   EventType event,
+                                                   size_t handled_events,
+                                                   size_t fired_events) {
+  if (!fired_events || ShouldExcludeForHistogram(scope))
     return;
-  int unhandled_ratio = (fired_events - handled_events) * 100 / fired_events;
-  UMA_HISTOGRAM_PERCENTAGE("ServiceWorker.UnhandledEventRatio",
-                           unhandled_ratio);
+  EventHandledRatioType type = EVENT_HANDLED_SOME;
+  if (fired_events == handled_events)
+    type = EVENT_HANDLED_ALL;
+  else if (handled_events == 0)
+    type = EVENT_HANDLED_NONE;
+  // For now Fetch is the only type that is recorded.
+  DCHECK_EQ(EVENT_TYPE_FETCH, event);
+  UMA_HISTOGRAM_ENUMERATION("ServiceWorker.EventHandledRatioType.Fetch", type,
+                            NUM_EVENT_HANDLED_RATIO_TYPE);
 }
 
 void ServiceWorkerMetrics::RecordFetchEventStatus(
     bool is_main_resource,
     ServiceWorkerStatusCode status) {
   if (is_main_resource) {
     UMA_HISTOGRAM_ENUMERATION("ServiceWorker.FetchEvent.MainResource.Status",
                               status, SERVICE_WORKER_ERROR_MAX_VALUE);
   } else {
     UMA_HISTOGRAM_ENUMERATION("ServiceWorker.FetchEvent.Subresource.Status",
                               status, SERVICE_WORKER_ERROR_MAX_VALUE);
   }
 }
 
 void ServiceWorkerMetrics::RecordURLRequestJobResult(
     bool is_main_resource,
     URLRequestJobResult result) {
   if (is_main_resource) {
     UMA_HISTOGRAM_ENUMERATION("ServiceWorker.URLRequestJob.MainResource.Result",
                               result, NUM_REQUEST_JOB_RESULT_TYPES);
   } else {
     UMA_HISTOGRAM_ENUMERATION("ServiceWorker.URLRequestJob.Subresource.Result",
                               result, NUM_REQUEST_JOB_RESULT_TYPES);
   }
 }
 
 }  // namespace content