Update ServiceWorker event handled status histogram

content/browser/service_worker/service_worker_version.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_version.h"
 
+#include <map>
+#include <string>
+
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/memory/ref_counted.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/stl_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/time/time.h"
@@ skipping 370 matching lines @@
   stashed_port_manager->AddPort(service_worker.get(), message_port_id, name);
 }
 
 }  // namespace
 
 const int ServiceWorkerVersion::kStartWorkerTimeoutMinutes = 5;
 const int ServiceWorkerVersion::kRequestTimeoutMinutes = 5;
 
 class ServiceWorkerVersion::Metrics {
  public:
-  Metrics() {}
+  using EventType = ServiceWorkerMetrics::EventType;
+  Metrics(const GURL& scope) : scope_(scope) {}

[falken, 2015/06/25 09:31:39]

nit: explicit

[kinuko, 2015/07/02 14:27:26]

Acknowledged.

   ~Metrics() {
-    ServiceWorkerMetrics::RecordEventStatus(fired_events, handled_events);
+    for (const auto& ev : event_stats_) {
+      ServiceWorkerMetrics::RecordPerWorkerEventHandledStatus(
+          scope_, ev.first, ev.second.handled_events, ev.second.fired_events);
+    }
   }
 
-  void RecordEventStatus(bool handled) {
-    ++fired_events;
+  void RecordEventHandledStatus(EventType event, bool handled) {
+    ServiceWorkerMetrics::RecordEventHandledStatus(scope_, event, handled);
+    event_stats_[event].fired_events++;
     if (handled)
-      ++handled_events;
+      event_stats_[event].handled_events++;
   }
 
  private:
-  size_t fired_events = 0;
-  size_t handled_events = 0;
+  struct EventStat {
+    size_t fired_events = 0;
+    size_t handled_events = 0;
+  };
+
+  const GURL scope_;
+  std::map<EventType, EventStat> event_stats_;
   DISALLOW_COPY_AND_ASSIGN(Metrics);
 };
 
 // A controller for periodically sending a ping to the worker to see
 // if the worker is not stalling.
 class ServiceWorkerVersion::PingController {
  public:
   explicit PingController(ServiceWorkerVersion* version) : version_(version) {}
   ~PingController() {}
 
@@ skipping 52 matching lines @@
     const GURL& script_url,
     int64 version_id,
     base::WeakPtr<ServiceWorkerContextCore> context)
     : version_id_(version_id),
       registration_id_(registration->id()),
       script_url_(script_url),
       scope_(registration->pattern()),
       context_(context),
       script_cache_map_(this, context),
       ping_controller_(new PingController(this)),
-      metrics_(new Metrics),
+      metrics_(new Metrics(scope_)),
       weak_factory_(this) {
   DCHECK(context_);
   DCHECK(registration);
   context_->AddLiveVersion(this);
   embedded_worker_ = context_->embedded_worker_registry()->CreateWorker();
   embedded_worker_->AddListener(this);
 }
 
 ServiceWorkerVersion::~ServiceWorkerVersion() {
   // The user may have closed the tab waiting for SW to start up.
@@ skipping 846 matching lines @@
                "ServiceWorkerVersion::OnFetchEventFinished",
                "Request id", request_id);
   FetchCallback* callback = fetch_callbacks_.Lookup(request_id);
   if (!callback) {
     NOTREACHED() << "Got unexpected message: " << request_id;
     return;
   }
 
   // TODO(kinuko): Record other event statuses too.
   const bool handled = (result == SERVICE_WORKER_FETCH_EVENT_RESULT_RESPONSE);
-  metrics_->RecordEventStatus(handled);
+  metrics_->RecordEventHandledStatus(ServiceWorkerMetrics::EVENT_TYPE_FETCH,
+                                     handled);
 
   scoped_refptr<ServiceWorkerVersion> protect(this);
   callback->Run(SERVICE_WORKER_OK, result, response);
   RemoveCallbackAndStopIfRedundant(&fetch_callbacks_, request_id);
 }
 
 void ServiceWorkerVersion::OnSyncEventFinished(
     int request_id,
     blink::WebServiceWorkerEventResult result) {
   TRACE_EVENT1("ServiceWorker",
@@ skipping 750 matching lines @@
     is_update_scheduled_ = false;
   }
 
   if (status != SERVICE_WORKER_OK || registration->active_version() != this)
     return;
   context_->UpdateServiceWorker(registration.get(),
                                 false /* force_bypass_cache */);
 }
 
 }  // namespace content