Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: tests/BadIcoTest.cpp

Issue 1178013008: Use the upstream version of libwebp, v0.4.3. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove README, put more info in config.h Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « resources/invalid_images/skbug3442.webp ('k') | third_party/libwebp/webp/config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/BadIcoTest.cpp
diff --git a/tests/BadIcoTest.cpp b/tests/BadIcoTest.cpp
index 9543d4b2f5fcc1cb21c207f9fdbacb6cd049abf6..240de514c981f2881d9ee356813fe2d4f760e87d 100644
--- a/tests/BadIcoTest.cpp
+++ b/tests/BadIcoTest.cpp
@@ -11,23 +11,25 @@
#include "SkImageDecoder.h"
#include "SkOSFile.h"
-DEF_TEST(BadIco, reporter) {
- const char* const badIcos [] = {
+DEF_TEST(BadImage, reporter) {
+ const char* const badImages [] = {
"sigabort_favicon.ico",
"sigsegv_favicon.ico",
"sigsegv_favicon_2.ico",
"ico_leak01.ico",
"ico_fuzz0.ico",
- "ico_fuzz1.ico"
+ "ico_fuzz1.ico",
+ "skbug3442.webp",
+ "skbug3429.webp",
};
- const char* badIcoFolder = "invalid_images";
+ const char* badImagesFolder = "invalid_images";
- SkString resourcePath = GetResourcePath(badIcoFolder);
+ SkString resourcePath = GetResourcePath(badImagesFolder);
SkBitmap bm;
- for (size_t i = 0; i < SK_ARRAY_COUNT(badIcos); ++i) {
- SkString fullPath = SkOSPath::Join(resourcePath.c_str(), badIcos[i]);
+ for (size_t i = 0; i < SK_ARRAY_COUNT(badImages); ++i) {
+ SkString fullPath = SkOSPath::Join(resourcePath.c_str(), badImages[i]);
bool success = SkImageDecoder::DecodeFile(fullPath.c_str(), &bm);
// These files are invalid, and should not decode. More importantly,
// though, we reached here without crashing.
« no previous file with comments | « resources/invalid_images/skbug3442.webp ('k') | third_party/libwebp/webp/config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698