Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1177983009: Move remoting-specific adapters from jingle/glue to remoting/protocol (Closed)

Created:
5 years, 6 months ago by Sergey Ulanov
Modified:
5 years, 5 months ago
Reviewers:
weitao
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move remoting-specific adapters from jingle/glue to remoting/protocol PseudoTcpAdapter and ChannelSocketAdapter are used only in remoting, so remoting/protocol is a better place for them. This change also includes two very minor cleanups in the moved code: 1. scoped_ptr<> is used to pass socket ownership in PseudoTcpAdapter 2. base::ThreadCheker is now used to check threads in ChannelSocketAdapter instead of base::MessageLoop::current(). Committed: https://crrev.com/031ce3b33ef0970136c157a35605d8c2917d58e8 Cr-Commit-Position: refs/heads/master@{#337432}

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : update GN #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -1658 lines) Patch
M jingle/BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
D jingle/glue/channel_socket_adapter.h View 1 chunk +0 lines, -86 lines 0 comments Download
D jingle/glue/channel_socket_adapter.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D jingle/glue/channel_socket_adapter_unittest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D jingle/glue/pseudotcp_adapter.h View 1 chunk +0 lines, -97 lines 0 comments Download
D jingle/glue/pseudotcp_adapter.cc View 1 chunk +0 lines, -606 lines 0 comments Download
D jingle/glue/pseudotcp_adapter_unittest.cc View 1 chunk +0 lines, -444 lines 0 comments Download
M jingle/jingle.gyp View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M jingle/jingle.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A + remoting/protocol/channel_socket_adapter.h View 1 4 chunks +15 lines, -15 lines 0 comments Download
A + remoting/protocol/channel_socket_adapter.cc View 7 chunks +15 lines, -15 lines 0 comments Download
A + remoting/protocol/channel_socket_adapter_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + remoting/protocol/pseudotcp_adapter.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + remoting/protocol/pseudotcp_adapter.cc View 6 chunks +12 lines, -11 lines 0 comments Download
A + remoting/protocol/pseudotcp_adapter_unittest.cc View 5 chunks +10 lines, -15 lines 0 comments Download
M remoting/protocol/pseudotcp_channel_factory.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/remoting_srcs.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Sergey Ulanov
5 years, 6 months ago (2015-06-18 22:01:52 UTC) #2
weitao
https://codereview.chromium.org/1177983009/diff/1/remoting/protocol/channel_socket_adapter.h File remoting/protocol/channel_socket_adapter.h (right): https://codereview.chromium.org/1177983009/diff/1/remoting/protocol/channel_socket_adapter.h#newcode30 remoting/protocol/channel_socket_adapter.h:30: // the adapter. Nit: s/this\ the/this/. Also maybe s/the\ ...
5 years, 6 months ago (2015-06-19 21:38:00 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1177983009/diff/1/remoting/protocol/channel_socket_adapter.h File remoting/protocol/channel_socket_adapter.h (right): https://codereview.chromium.org/1177983009/diff/1/remoting/protocol/channel_socket_adapter.h#newcode30 remoting/protocol/channel_socket_adapter.h:30: // the adapter. On 2015/06/19 21:37:59, weitao wrote: > ...
5 years, 6 months ago (2015-06-19 22:01:35 UTC) #4
weitao
LGTM https://codereview.chromium.org/1177983009/diff/1/remoting/protocol/pseudotcp_adapter_unittest.cc File remoting/protocol/pseudotcp_adapter_unittest.cc (right): https://codereview.chromium.org/1177983009/diff/1/remoting/protocol/pseudotcp_adapter_unittest.cc#newcode310 remoting/protocol/pseudotcp_adapter_unittest.cc:310: FakeSocket* host_socket_; On 2015/06/19 22:01:34, Sergey Ulanov wrote: ...
5 years, 6 months ago (2015-06-19 22:45:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177983009/20001
5 years, 6 months ago (2015-06-19 22:48:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/101467)
5 years, 6 months ago (2015-06-19 23:51:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177983009/60001
5 years, 5 months ago (2015-07-06 17:21:05 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-06 19:00:57 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 19:06:28 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/031ce3b33ef0970136c157a35605d8c2917d58e8
Cr-Commit-Position: refs/heads/master@{#337432}

Powered by Google App Engine
This is Rietveld 408576698