Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1177983006: DevTools: remove InspectorCSSId, it serves no purpose. (Closed)

Created:
5 years, 6 months ago by pfeldman
Modified:
5 years, 6 months ago
Reviewers:
kozy, dgozman, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: remove InspectorCSSId, it serves no purpose. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197119

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 1

Patch Set 4 : properly encoding rules from UA styles. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -178 lines) Patch
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 19 chunks +41 lines, -41 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 10 chunks +28 lines, -52 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 3 34 chunks +84 lines, -85 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pfeldman
5 years, 6 months ago (2015-06-13 12:31:23 UTC) #2
kozy
lgtm https://codereview.chromium.org/1177983006/diff/40001/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp (right): https://codereview.chromium.org/1177983006/diff/40001/Source/core/inspector/InspectorStyleSheet.cpp#newcode1892 Source/core/inspector/InspectorStyleSheet.cpp:1892: ASSERT_UNUSED(!ruleIndex, !ruleIndex); ASSERT_UNUSED(ruleIndex, !ruleIndex)
5 years, 6 months ago (2015-06-15 09:49:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177983006/60001
5 years, 6 months ago (2015-06-15 09:55:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/66589)
5 years, 6 months ago (2015-06-15 11:28:15 UTC) #10
lushnikov
awesome https://codereview.chromium.org/1177983006/diff/60001/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp (left): https://codereview.chromium.org/1177983006/diff/60001/Source/core/inspector/InspectorStyleSheet.cpp#oldcode1328 Source/core/inspector/InspectorStyleSheet.cpp:1328: ASSERT(!id.isEmpty()); should be ASSERT(!id().isEmpty());
5 years, 6 months ago (2015-06-15 12:16:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177983006/80001
5 years, 6 months ago (2015-06-15 14:16:14 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 15:25:10 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197119

Powered by Google App Engine
This is Rietveld 408576698