Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1177973005: Correct ENABLE_MEDIA_ROUTER defines to fix compilation without it. (Closed)

Created:
5 years, 6 months ago by mharanczyk
Modified:
5 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, apacible, ben+mojo_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correct ENABLE_MEDIA_ROUTER defines to fix compilation without it. Committed: https://crrev.com/f6d0a228e210cbcd96b6ef494cadbf12c09b62ea Cr-Commit-Position: refs/heads/master@{#334134}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/extensions/chrome_mojo_service_registration.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/component_extensions_whitelist/whitelist.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mharanczyk
Simple addition/move of define ENABLE_MEDIA_ROUTER where needed, please take a look.
5 years, 6 months ago (2015-06-11 16:24:08 UTC) #2
Devlin
lgtm. +Jennifer (media router action) for FYI. https://codereview.chromium.org/1177973005/diff/1/chrome/browser/extensions/chrome_mojo_service_registration.cc File chrome/browser/extensions/chrome_mojo_service_registration.cc (right): https://codereview.chromium.org/1177973005/diff/1/chrome/browser/extensions/chrome_mojo_service_registration.cc#newcode31 chrome/browser/extensions/chrome_mojo_service_registration.cc:31: content::ServiceRegistry* service_registry ...
5 years, 6 months ago (2015-06-11 16:42:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177973005/20001
5 years, 6 months ago (2015-06-12 08:11:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/70445)
5 years, 6 months ago (2015-06-12 08:18:04 UTC) #8
mharanczyk
On 2015/06/12 08:18:04, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-12 08:26:43 UTC) #10
jochen (gone - plz use gerrit)
rationale: restricting an existing component extension is fine LGTM
5 years, 6 months ago (2015-06-12 08:28:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177973005/20001
5 years, 6 months ago (2015-06-12 08:32:45 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-12 09:11:51 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 09:12:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6d0a228e210cbcd96b6ef494cadbf12c09b62ea
Cr-Commit-Position: refs/heads/master@{#334134}

Powered by Google App Engine
This is Rietveld 408576698