media/midi/midi_manager_usb.cc - Issue 1177973003: [Web MIDI] Use Android MIDI API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/midi/midi_manager_usb.cc

Issue 1177973003: [Web MIDI] Use Android MIDI API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/midi/midi_manager_usb.cc

diff --git a/media/midi/midi_manager_usb.cc b/media/midi/midi_manager_usb.cc

index f493b151c884e89cb4f09ab22bbf9781d0a63ae0..9e4778c3b39f7ae6126ab2572ec78a6574e50e48 100644

--- a/media/midi/midi_manager_usb.cc

+++ b/media/midi/midi_manager_usb.cc

@@ -137,7 +137,7 @@ bool MidiManagerUsb::AddPorts(UsbMidiDevice* device, int device_id) {

// sufficiently unique although there is no user-friendly meaning.

// TODO(yhirano): Use a hashed string as ID.

std::string id(

- base::StringPrintf("port-%d-%ld", device_id, static_cast<long>(j)));

+ base::StringPrintf("usb:port-%d-%ld", device_id, static_cast<long>(j)));

if (jacks[j].direction() == UsbMidiJack::DIRECTION_OUT) {

output_streams_.push_back(new UsbMidiOutputStream(jacks[j]));

AddOutputPort(MidiPortInfo(id, manufacturer, product_name, version,

« no previous file with comments | « media/midi/midi_manager_android.cc ('k') | media/midi/midi_manager_usb_unittest.cc » ('j') | no next file with comments »