Support new style JS interop

Source/bindings/core/dart/DartInjectedScript.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 954 matching lines @@
 
 void DartInjectedScript::getProperties(ErrorString* errorString, const String& objectId, bool ownProperties, bool accessorPropertiesOnly, RefPtr<Array<PropertyDescriptor> >* properties)
 {
     Dart_Handle exception = 0;
     if (!m_scriptState) {
         *errorString = "Invalid DartInjectedScript";
         return;
     }
     DartIsolateScope scope(m_scriptState->isolate());
     DartApiScope apiScope;
+    DartDOMData* domData = DartDOMData::current();
+    V8Scope v8scope(domData);

[Jacob, 2015/06/18 22:22:44]

Not sure why this ever worked without a V8Scope

 
     DartDebuggerObject* object = lookupObject(objectId);
     if (!object) {
         *errorString = "Unknown objectId";
         return;
     }
     Dart_Handle handle = object->handle();
     String objectGroup = object->group();
 
     *properties = Array<PropertyDescriptor>::create();
@@ skipping 117 matching lines @@
 
     if (object->kind() == DartDebuggerObject::Object && !accessorPropertiesOnly && !Dart_IsNull(handle)) {
         RefPtr<PropertyDescriptor> descriptor = PropertyDescriptor::create().setName("[[class]]").setConfigurable(false).setEnumerable(true).release();
         descriptor->setValue(wrapDartHandle(handle, DartDebuggerObject::ObjectClass, objectGroup, false));
         descriptor->setWritable(false);
         descriptor->setWasThrown(false);
         descriptor->setIsOwn(true);
         (*properties)->addItem(descriptor);
 
         if (DartDOMWrapper::subtypeOf(handle, JsObject::dartClassId)) {
-            DartDOMData* domData = DartDOMData::current();
             JsObject* object = DartDOMWrapper::unwrapDartWrapper<JsObject>(domData, handle, exception);
             if (!exception) {
                 descriptor = PropertyDescriptor::create().setName("[[JavaScript View]]").setConfigurable(false).setEnumerable(true).release();
 
                 V8ScriptState* v8ScriptState = DartUtilities::v8ScriptStateForCurrentIsolate();
                 InjectedScript v8InjectedScript = m_injectedScriptManager->injectedScriptFor(v8ScriptState);
                 ScriptValue v8ScriptValue(v8ScriptState, object->localV8Object());
                 descriptor->setValue(v8InjectedScript.wrapObject(v8ScriptValue, objectGroup, false));
                 descriptor->setWritable(false);
                 descriptor->setWasThrown(false);
@@ skipping 14 matching lines @@
     *properties = Array<InternalPropertyDescriptor>::create();
 }
 
 void DartInjectedScript::getProperty(ErrorString* errorString, const String& objectId, const RefPtr<JSONArray>& propertyPath, RefPtr<TypeBuilder::Runtime::RemoteObject>* result, TypeBuilder::OptOutput<bool>* wasThrown)
 {
     if (!m_scriptState) {
         *errorString = "Invalid DartInjectedScript";
         return;
     }
     DartIsolateScope scope(m_scriptState->isolate());
+    DartDOMData* domData = DartDOMData::current();
+    V8Scope v8scope(domData);
     DartApiScope apiScope;
 
     DartDebuggerObject* object = lookupObject(objectId);
     if (!object) {
         *errorString = "Unknown objectId";
         return;
     }
     Dart_Handle handle = object->handle();
     const String& objectGroup = object->group();
 
@@ skipping 283 matching lines @@
     RefPtr<JSONValue> parsedObjectId = parseJSON(objectId);
     if (parsedObjectId && parsedObjectId->type() == JSONValue::TypeObject) {
         bool isDart = false;
         bool success = parsedObjectId->asObject()-> getBoolean("isDart", &isDart);
         return success && isDart;
     }
     return false;
 }
 
 } // namespace blink