Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1177953002: Make sure we do not start incremental marking in idle notification when incremental marking is turn… (Closed)

Created:
5 years, 6 months ago by Hannes Payer (out of office)
Modified:
5 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sure we do not start incremental marking in idle notification when incremental marking is turned off via flags. BUG=chromium:498315 LOG=n Committed: https://crrev.com/6928465bd941fb575d5765b9b68ea23944be4d95 Cr-Commit-Position: refs/heads/master@{#28925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/heap/gc-idle-time-handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Hannes Payer (out of office)
5 years, 6 months ago (2015-06-11 01:15:55 UTC) #2
ulan
lgtm
5 years, 6 months ago (2015-06-11 07:39:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177953002/1
5 years, 6 months ago (2015-06-11 07:40:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 07:41:40 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 07:41:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6928465bd941fb575d5765b9b68ea23944be4d95
Cr-Commit-Position: refs/heads/master@{#28925}

Powered by Google App Engine
This is Rietveld 408576698