Resolve RFC 6761 localhost names to loopback

net/test/spawned_test_server/base_test_server.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/spawned_test_server/base_test_server.h"
 
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 218 matching lines @@
       NOTREACHED();
   }
   return std::string();
 }
 
 bool BaseTestServer::GetAddressList(AddressList* address_list) const {
   DCHECK(address_list);
 
   scoped_ptr<HostResolver> resolver(HostResolver::CreateDefaultResolver(NULL));
   HostResolver::RequestInfo info(host_port_pair_);
+  // Do an IPv4 lookup since kLocalhost is IPv4.

[Ryan Sleevi, 2015/06/19 23:08:16]

nit: maybe expand/reword the comment

// Limit the lookup to IPv4. When started with the default
// address of kLocalhost, testserver.py only supports IPv4.
// If a custom hostname is used, it's possible that the test
// server will listen on both IPv4 and IPv6, so this will
// still work. The testserver does not support explicit
// IPv6 literal hostnames.

[estark, 2015/06/19 23:17:36]

Done.

+  info.set_address_family(ADDRESS_FAMILY_IPV4);
   TestCompletionCallback callback;
   int rv = resolver->Resolve(info,
                              DEFAULT_PRIORITY,
                              address_list,
                              callback.callback(),
                              NULL,
                              BoundNetLog());
   if (rv == ERR_IO_PENDING)
     rv = callback.WaitForResult();
   if (rv != OK) {
@@ skipping 258 matching lines @@
 
   return GenerateAdditionalArguments(arguments);
 }
 
 bool BaseTestServer::GenerateAdditionalArguments(
     base::DictionaryValue* arguments) const {
   return true;
 }
 
 }  // namespace net