Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1177923004: Revert of Run mojo unit tests on the Android main waterfall. (Closed)

Created:
5 years, 6 months ago by msw
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Run mojo unit tests on the Android main waterfall. (patchset #2 id:20001 of https://codereview.chromium.org/1145343005/) Reason for revert: http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/26585/steps/compile/logs/stdio#error1 ninja:error: unknown target 'html_viewer_unittests_apk' Original issue's description: > Run mojo unit tests on the Android main waterfall. > > Run Mojo additional unit tests on the "Android GN" bot: > http://build.chromium.org/p/chromium.linux/builders/Android%20GN > (No CQ yet; need Android GN testing support/devices there...) > Add the necessary target mappings to ninja_to_gn.pyl > > Similar tests already run on Linux GN and our chromium.mojo FYI: > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN > http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android > > BUG=478244, 359249 > TEST=Steps run and pass on the bot. > R=dpranke@chromium.org > > Committed: https://crrev.com/e1d8b35e1745d299ef346b1b6b6d116f417d2664 > Cr-Commit-Position: refs/heads/master@{#335112} TBR=dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478244, 359249 Committed: https://crrev.com/04bec3df9c1a8cce0f8faf13214db256cd3f55bd Cr-Commit-Position: refs/heads/master@{#335117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -39 lines 0 comments Download
M testing/buildbot/ninja_to_gn.pyl View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Created Revert of Run mojo unit tests on the Android main waterfall.
5 years, 6 months ago (2015-06-18 20:55:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177923004/1
5 years, 6 months ago (2015-06-18 20:56:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 20:59:01 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/04bec3df9c1a8cce0f8faf13214db256cd3f55bd Cr-Commit-Position: refs/heads/master@{#335117}
5 years, 6 months ago (2015-06-18 21:00:06 UTC) #4
Dirk Pranke
5 years, 6 months ago (2015-06-18 21:39:02 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698