Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1177913002: [Retry] ServiceWorker: Implement ServiceWorkerRegistration.update() (1) (Closed)

Created:
4 years, 10 months ago by nhiroki
Modified:
4 years, 10 months ago
Reviewers:
kinuko, tkent
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Retry] ServiceWorker: Implement ServiceWorkerRegistration.update() (1) The difference from the original patch is to route an update request through WebServiceWorkerRegistration instead of WebServiceWorkerProvider. See (2) for details. Original patch: https://codereview.chromium.org/1166283006/ Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-update Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/bvi8fXqvNhs (1) Blink: THIS PATCH (2) Chromium: https://codereview.chromium.org/1175823002 (3) Blink: https://codereview.chromium.org/1177563005 BUG=450507 TEST=will be added by (3) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197017

Patch Set 1 : original #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : remove const #

Messages

Total messages: 11 (3 generated)
kinuko
Yup, looks much simpler now. (Let's consider making unregister go through the registration interface too)
4 years, 10 months ago (2015-06-11 03:45:18 UTC) #2
kinuko
https://codereview.chromium.org/1177913002/diff/20001/public/platform/WebServiceWorkerRegistration.h File public/platform/WebServiceWorkerRegistration.h (right): https://codereview.chromium.org/1177913002/diff/20001/public/platform/WebServiceWorkerRegistration.h#newcode24 public/platform/WebServiceWorkerRegistration.h:24: virtual void update(WebServiceWorkerProvider*) const { } It's probably not ...
4 years, 10 months ago (2015-06-11 03:49:52 UTC) #3
nhiroki
Updated! Can you take another look? Thanks. https://codereview.chromium.org/1177913002/diff/20001/public/platform/WebServiceWorkerRegistration.h File public/platform/WebServiceWorkerRegistration.h (right): https://codereview.chromium.org/1177913002/diff/20001/public/platform/WebServiceWorkerRegistration.h#newcode24 public/platform/WebServiceWorkerRegistration.h:24: virtual void ...
4 years, 10 months ago (2015-06-11 04:43:26 UTC) #4
kinuko
lgtm
4 years, 10 months ago (2015-06-11 06:36:46 UTC) #5
nhiroki
tkent@: Can you take another look at public/platform? The difference from the original patch is ...
4 years, 10 months ago (2015-06-11 06:55:30 UTC) #7
tkent
lgtm
4 years, 10 months ago (2015-06-11 06:56:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177913002/40001
4 years, 10 months ago (2015-06-12 07:29:53 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-12 08:45:57 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197017

Powered by Google App Engine
This is Rietveld 408576698