Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11779036: Revert 175471 (Closed)

Created:
7 years, 11 months ago by Lei Zhang
Modified:
7 years, 11 months ago
Reviewers:
Greg Billock
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Revert 175471 > [Media Galleries] Add an ImageCaptureCore listener for Mac. (part 2) > > This listener uses the ImageCapture API to watch for attach and detach > events of PTP devices and other devices which can be read through the > library. It forwards such notifications through the SystemMonitor. > > Also provides an API for clients to access such devices directly and > retrieve the media contents from them. > > R=thestig@chromium.org,sail@chromium.org > BUG=151681 > > > Review URL: https://chromiumcodereview.appspot.com/11442057 TBR=gbillock@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -814 lines) Patch
M base/mac/cocoa_protocols.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/system_monitor/disk_info_mac.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/system_monitor/disk_info_mac.mm View 1 chunk +13 lines, -0 lines 0 comments Download
D chrome/browser/system_monitor/image_capture_device.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/system_monitor/image_capture_device.mm View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/browser/system_monitor/image_capture_device_manager.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/system_monitor/image_capture_device_manager.mm View 1 chunk +0 lines, -139 lines 0 comments Download
D chrome/browser/system_monitor/image_capture_device_manager_unittest.mm View 1 chunk +0 lines, -354 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
7 years, 11 months ago (2013-01-08 02:30:46 UTC) #1
Lei Zhang
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/35115/steps/compile/logs/stdio FAILED: clang++ -MMD -MF obj/chrome/browser/system_monitor/browser.image_capture_device_manager.o.d -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_THREADING -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH ...
7 years, 11 months ago (2013-01-08 02:31:12 UTC) #2
Greg Billock
7 years, 11 months ago (2013-01-08 16:10:14 UTC) #3
Message was sent while issue was closed. 
On 2013/01/08 02:31:12, Lei Zhang wrote:
>
http://build.chromium.org/p/chromium.mac/builders/Mac%2520Builder%2520%2528db...
> 
> FAILED: clang++ -MMD -MF
> obj/chrome/browser/system_monitor/browser.image_capture_device_manager.o.d
> -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1
> -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
> -DENABLE_PEPPER_THREADING -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH
> -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1
> -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1
> -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1
> -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1
> -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_LANGUAGE_DETECTION=1
> -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DNACL_WINDOWS=0
> -DNACL_LINUX=0 -DNACL_OSX=1 -DNACL_TARGET_SUBARCH=32 -DNACL_TARGET_ARCH=x86
> -DNACL_BUILD_SUBARCH=32 -DNACL_BUILD_ARCH=x86 -DFULL_SAFE_BROWSING
> -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGURL_DLL
> -DNO_NSPR_10_SUPPORT -DNSS_ENABLE_ECC -DNSS_STATIC -DNSS_USE_STATIC_LIBS
> -DUSE_UTIL_DIRECTLY -DSK_BUILD_NO_IMAGE_ENCODE
-DSK_DEFERRED_CANVAS_USES_GPIPE=1
> '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
> -DGR_AGGRESSIVE_SHADER_OPTS=1 -DSK_USE_POSIX_THREADS -DGR_DLL -DSKIA_DLL
> -DU_USING_ICU_NAMESPACE=0 -DLIBXML_STATIC -DXML_STATIC -DHUNSPELL_STATIC
> -DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL -DFEATURE_ENABLE_SSL
> -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH
> -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DOSX
> -DPOSIX -DV8_SHARED -DUSING_V8_SHARED -DUSE_CUPS -DCLD_WINDOWS -DCOMPILER_GCC
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-DDYNAMIC_ANNOTATIONS_ENABLED=1
> -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../../third_party/icu/public/common
> -I../../third_party/icu/public/i18n -I../.. -Iobj/chrome/browser.gen -Igen
> -I../../third_party/GTM -I../../third_party/GTM/DebugUtils
> -I../../third_party/GTM/Foundation -I../../third_party/khronos -I../../gpu
> -I../../third_party/WebKit/Source/Platform/chromium -Igen/protoc_out
> -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome
> -I../../third_party/nss/mozilla/nsprpub/pr/include
> -I../../third_party/nss/mozilla/nsprpub/lib/ds
> -I../../third_party/nss/mozilla/nsprpub/lib/libc/include
> -I../../third_party/nss/mozilla/security/nss/lib/base
> -I../../third_party/nss/mozilla/security/nss/lib/certdb
> -I../../third_party/nss/mozilla/security/nss/lib/certhigh
> -I../../third_party/nss/mozilla/security/nss/lib/cryptohi
> -I../../third_party/nss/mozilla/security/nss/lib/dev
> -I../../third_party/nss/mozilla/security/nss/lib/freebl
> -I../../third_party/nss/mozilla/security/nss/lib/freebl/ecl
> -I../../third_party/nss/mozilla/security/nss/lib/nss
> -I../../third_party/nss/mozilla/security/nss/lib/pk11wrap
> -I../../third_party/nss/mozilla/security/nss/lib/pkcs7
> -I../../third_party/nss/mozilla/security/nss/lib/pki
> -I../../third_party/nss/mozilla/security/nss/lib/smime
> -I../../third_party/nss/mozilla/security/nss/lib/softoken
> -I../../third_party/nss/mozilla/security/nss/lib/util -I../../skia/config
> -I../../third_party/skia/src/core -I../../third_party/skia/include/config
> -I../../third_party/skia/include/core -I../../third_party/skia/include/effects
> -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
> -I../../third_party/skia/include/gpu/gl -I../../third_party/skia/include/pipe
> -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
> -I../../skia/ext -I../../third_party/skia/include/utils/mac
> -I../../third_party/bzip2 -I../../third_party/cacheinvalidation/overrides
> -I../../third_party/cacheinvalidation/src
> -I../../third_party/cacheinvalidation/google/cacheinvalidation
> -I../../third_party/libxml/mac/include -I../../third_party/libxml/src/include
> -I../../third_party/zlib -Igen/ui/app_locale_settings -Igen/ui/ui_strings
> -Igen/ui/ui_resources -I../../third_party/expat/files/lib
> -I../../third_party/leveldatabase/src/include
> -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
> -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source
> -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc
> -I../../third_party/jsoncpp/overrides/include
> -I../../third_party/jsoncpp/source/include
> -Igen/protoc_out/third_party/libphonenumber
> -I../../third_party/libphonenumber/src -I../../third_party/libusb
> -I../../third_party/npapi -I../../third_party/npapi/bindings
> -I../../third_party/re2 -Igen/ui/gl -I../../third_party/mesa/MesaLib/include
> -I../../v8/include -Igen/webkit -Igen/policy -I../../third_party/cld -isysroot
> /Developer/SDKs/MacOSX10.6.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror
> -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels
-Wextra
> -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene
> -Wno-c++11-narrowing -Wno-reserved-user-defined-literal -Wno-char-subscripts
> -Wno-unused-function -Wno-covered-switch-default -Wexit-time-destructors
> -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics
> -Xclang -load -Xclang
>
/b/build/slave/Mac_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> -Xclang -add-plugin -Xclang find-bad-constructs -Xclang
> -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations
> -fcolor-diagnostics -fno-strict-aliasing -fstack-protector-all -std=gnu++11
> -fobjc-call-cxx-cdtors  -c
> ../../chrome/browser/system_monitor/image_capture_device_manager.mm -o
> obj/chrome/browser/system_monitor/browser.image_capture_device_manager.o
> ../../chrome/browser/system_monitor/image_capture_device_manager.mm:94:31:
> error: instance method '-mountPoint' not found (return type defaults to 'id')
> [-Werror,-Wobjc-method-access]
>       base::SysNSStringToUTF8([cameraDevice mountPoint]));
>                               ^             ~~~~~~~~~~
> 1 error generated.

lgtm

Powered by Google App Engine
This is Rietveld 408576698