Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1177903005: [test] More debugging output in test runner. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] More debugging output in test runner. Also use again the taskkill method, recently removed in https://codereview.chromium.org/1156133006/ BUG=chromium:485932 LOG=n TBR=jkummerow@chromium.org NOTREECHECKS=true Committed: https://crrev.com/6a1093182064ffaf560542c3598045dc37842a65 Cr-Commit-Position: refs/heads/master@{#29001}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M tools/testrunner/local/commands.py View 1 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Achenbach
PTAL
5 years, 6 months ago (2015-06-12 13:04:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177903005/20001
5 years, 6 months ago (2015-06-12 13:04:20 UTC) #4
tandrii(chromium)
lgtm
5 years, 6 months ago (2015-06-12 13:20:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-12 13:29:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177903005/20001
5 years, 6 months ago (2015-06-12 13:42:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-12 13:43:58 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 13:44:05 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a1093182064ffaf560542c3598045dc37842a65
Cr-Commit-Position: refs/heads/master@{#29001}

Powered by Google App Engine
This is Rietveld 408576698