Fix Intrinsifier and MethodRecognizer to correctly match private getters and setters.

runtime/vm/intrinsifier.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Class for intrinsifying functions.
 
 #include "vm/intrinsifier.h"
 #include "vm/flags.h"
 #include "vm/object.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, intrinsify, true, "Instrinsify when possible");
 
 
 static bool CompareNames(const char* test_name, const char* name) {
-  if (strcmp(test_name, name) == 0) {
+  static const intptr_t kPrefixLength = 5;
+  static const char* kGetterPrefix = "get:_";
+  static const char* kSetterPrefix = "set:_";

[Florian Schneider, 2013/01/07 13:15:48]

I'd define those in one place and remove kPrefixLength in favor of strlen(...).

[Vyacheslav Egorov (Google), 2013/01/07 15:02:47]

I renamed & started to use strlen. 

I am however going to keep it here. Later we will refactor method recognizer and
intrinsifier to use the same code. 

+
+  if (test_name[0] == '_') {
+    if (name[0] != '_') {
+      return false;
+    }
+  } else if (strncmp(test_name, kGetterPrefix, kPrefixLength) == 0) {
+    if (strncmp(name, kGetterPrefix, kPrefixLength) != 0) {
+      return false;
+    }
+  } else if (strncmp(test_name, kSetterPrefix, kPrefixLength) == 0) {
+    if (strncmp(name, kSetterPrefix, kPrefixLength) != 0) {
+      return false;
+    }
+  } else {
+    return (strcmp(test_name, name) == 0);
+  }
+
+  // Check if the private class is member of core or scalarlist and matches
+  // the test_class_name.
+  const Library& core_lib = Library::Handle(Library::CoreLibrary());
+  const Library& scalarlist_lib =
+      Library::Handle(Library::ScalarlistLibrary());
+  String& test_str = String::Handle(String::New(test_name));
+  String& test_str_with_key = String::Handle();
+  test_str_with_key =
+      String::Concat(test_str, String::Handle(core_lib.private_key()));
+  if (strcmp(test_str_with_key.ToCString(), name) == 0) {
     return true;
   }
-  if ((name[0] == '_') && (test_name[0] == '_')) {
-    // Check if the private class is member of core or scalarlist and matches
-    // the test_class_name.
-    const Library& core_lib = Library::Handle(Library::CoreLibrary());
-    const Library& scalarlist_lib =
-        Library::Handle(Library::ScalarlistLibrary());
-    String& test_str = String::Handle(String::New(test_name));
-    String& test_str_with_key = String::Handle();
-    test_str_with_key =
-        String::Concat(test_str, String::Handle(core_lib.private_key()));
-    if (strcmp(test_str_with_key.ToCString(), name) == 0) {
-      return true;
-    }
-    test_str_with_key =
-        String::Concat(test_str, String::Handle(scalarlist_lib.private_key()));
-    if (strcmp(test_str_with_key.ToCString(), name) == 0) {
-      return true;
-    }
+  test_str_with_key =
+      String::Concat(test_str, String::Handle(scalarlist_lib.private_key()));
+  if (strcmp(test_str_with_key.ToCString(), name) == 0) {
+    return true;
   }
+
   return false;
 }
 
 
 // Returns true if the function matches function_name and class_name, with
 // special recognition of corelib private classes.
 static bool TestFunction(const Function& function,
                          const char* function_class_name,
                          const char* function_name,
                          const char* test_class_name,
@@ skipping 58 matching lines @@
     ASSERT(function.CheckSourceFingerprint(fp));                               \
     return destination(assembler);                                             \
   }                                                                            \
 
 INTRINSIC_LIST(FIND_INTRINSICS);
 #undef FIND_INTRINSICS
   return false;
 }
 
 }  // namespace dart