Roll Skia DEPS to r7044 & add SK_IGNORE_TRANS_CLAMP_FIX and SK_IGNORE_FAST_SCALEMATRIX_INVERT

Roll Skia DEPS to r7044 & add SK_IGNORE_TRANS_CLAMP_FIX and SK_IGNORE_FAST_SCALEMATRIX_INVERT

control: https://codereview.chromium.org/11791014/
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175328

[robertphillips, 2013-01-07 13:06:19]

I believe this is 'good'. The discrepancies between the roll and control are:

win
   roll:    
            interactive_ui_tests failed 1
                ReserveKeyboardAccelerators
            browser_tests failed 2
                Messaging
                ReloadRelaunches
   control: 
            green

linux_layout
   roll:    
            webkit_tests 944 fixable (0 skipped) failed 1
                styles-computed-trace.html
   control: 
            webkit_tests 949 fixable (0 skipped) failed 1
                live-edit.html

[bsalomon, 2013-01-07 13:39:06]

On 2013/01/07 13:06:19, robertphillips wrote:
> I believe this is 'good'. The discrepancies between the roll and control are:
> 
> win
>    roll:    
>             interactive_ui_tests failed 1
>                 ReserveKeyboardAccelerators
>             browser_tests failed 2
>                 Messaging
>                 ReloadRelaunches
>    control: 
>             green
> 
> linux_layout
>    roll:    
>             webkit_tests 944 fixable (0 skipped) failed 1
>                 styles-computed-trace.html
>    control: 
>             webkit_tests 949 fixable (0 skipped) failed 1
>                 live-edit.html

lgtm

[schenney, 2013-01-07 13:41:57]

Which of those gyp flags need to go into WebKit's skia gyp?
That is, which affect more than a few layout tests?

Stephen.


On Mon, Jan 7, 2013 at 8:39 AM, <bsalomon@google.com> wrote:

> On 2013/01/07 13:06:19, robertphillips wrote:
>
>> I believe this is 'good'. The discrepancies between the roll and control
>> are:
>>
>
>  win
>>     roll:
>>              interactive_ui_tests failed 1
>>                  ReserveKeyboardAccelerators
>>              browser_tests failed 2
>>                  Messaging
>>                  ReloadRelaunches
>>     control:
>>              green
>>
>
>  linux_layout
>>     roll:
>>              webkit_tests 944 fixable (0 skipped) failed 1
>>                  styles-computed-trace.html
>>     control:
>>              webkit_tests 949 fixable (0 skipped) failed 1
>>                  live-edit.html
>>
>
> lgtm
>
>
https://codereview.chromium.**org/11779016/<https://codereview.chromium.org/1...
>
> --
>
>
>


-- 
Stephen Chenney | Software Engineer | schenney@google.com | 404-314-1809

[robertphillips, 2013-01-07 13:46:23]

Here are the layout tests impacted by these two new flags:

SK_IGNORE_FAST_SCALEMATRIX_INVERT
https://codereview.chromium.org/11797003/

  fast/borders/border-image-massive-scale.html [ ImageOnlyFailure ]
  fast/borders/border-image-outset-in-shorthand.html [ ImageOnlyFailure ]
  fast/borders/border-image-outset.html [ ImageOnlyFailure ]
  fast/borders/border-image-scaled.html [ ImageOnlyFailure ]    - mac-only?
  fast/canvas/canvas-incremental-repaint.html [ ImageOnlyFailure ]
  fast/speech/input-appearance-searchandspeech.html [ ImageOnlyFailure ] -
linux-only?
 
platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers.html
[ ImageOnlyFailure ] - mac-only?
  svg/W3C-SVG-1.1-SE/pservers-grad-17-b.svg [ ImageOnlyFailure ]
  svg/W3C-SVG-1.1-SE/pservers-grad-20-b.svg [ ImageOnlyFailure ]
  svg/W3C-SVG-1.1/pservers-grad-17-b.svg [ ImageOnlyFailure ]
  svg/custom/non-scaling-stroke.svg [ ImageOnlyFailure ]
  tables/mozilla/bugs/bug137388-2.html [ ImageOnlyFailure ]
  tables/mozilla/bugs/bug23235.html [ ImageOnlyFailure ] - linux-only?
  tables/mozilla/bugs/bug4093.html [ ImageOnlyFailure ]

SK_IGNORE_TRANS_CLAMP_FIX
https://codereview.chromium.org/11801004/

  fast/borders/border-image-outset-split-inline-vertical-lr.html [
ImageOnlyFailure ]
  fast/borders/border-image-outset-split-inline.html [ ImageOnlyFailure ]
  fast/borders/border-image-slice-constrained.html [ ImageOnlyFailure ]
  fast/writing-mode/border-image-horizontal-bt.html [ ImageOnlyFailure ] -
mac-only?
  fast/writing-mode/border-image-vertical-lr.html [ ImageOnlyFailure ] -
mac-only?
  fast/writing-mode/border-image-vertical-rl.html [ ImageOnlyFailure ] -
mac-only?
  svg/W3C-SVG-1.1/coords-units-01-b.svg [ ImageOnlyFailure ]
  svg/batik/filters/feTile.svg [ ImageOnlyFailure ] - linux-only?
  svg/filters/feTile.svg [ ImageOnlyFailure ]