Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1177863002: ash: Restore user selected rotation on startup (Closed)

Created:
5 years, 6 months ago by dnicoara
Modified:
5 years, 6 months ago
Reviewers:
jonross, Jun Mukai, oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Restore user selected rotation on startup Display preferences saves the user selected rotation. We want to restore it on startup otherwise the rotation will not be restored after the first Chrome restart. Example reproduction steps: 1) Log in 2) Set rotation to 90 degrees 3) Restart chrome (this will be fine since it reads the 90 degree rotation, though it will write a rotation of 0 degrees) 4) Restart chrome (this will show with a rotation of 0 degrees) BUG=498895 Committed: https://crrev.com/a56eca844bbca1cdcb741b820ee9631b49252e00 Cr-Commit-Position: refs/heads/master@{#334152}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ash/display/display_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
dnicoara
5 years, 6 months ago (2015-06-10 22:37:57 UTC) #2
Jun Mukai
oshima, could you review this?
5 years, 6 months ago (2015-06-10 22:55:54 UTC) #4
oshima
lgtm but please wait for jonross@'s review.
5 years, 6 months ago (2015-06-11 00:03:43 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177863002/20001
5 years, 6 months ago (2015-06-11 13:53:22 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-11 14:24:24 UTC) #9
jonross
On 2015/06/11 14:24:24, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 6 months ago (2015-06-12 13:21:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177863002/20001
5 years, 6 months ago (2015-06-12 13:28:47 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-12 13:32:59 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 13:34:02 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a56eca844bbca1cdcb741b820ee9631b49252e00
Cr-Commit-Position: refs/heads/master@{#334152}

Powered by Google App Engine
This is Rietveld 408576698