Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1177843010: Delete sky-element framework (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Delete sky-element framework This framework is two generations old and has no clients. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/8af9c19a601aaa3b93ff21903f7a84ac4ff2db98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1423 lines) Patch
D sky/sdk/lib/framework/elements/animation/controller.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/sdk/lib/framework/elements/animation/timer.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/sdk/lib/framework/elements/material-element.sky View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/sdk/lib/framework/elements/shadow.sky View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-box.sky View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-button.sky View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-checkbox.sky View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-drawer.sky View 1 chunk +0 lines, -166 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-drawer-header.sky View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-element.sky View 1 chunk +0 lines, -164 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-icon.sky View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-ink-splash.sky View 1 chunk +0 lines, -98 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-input.sky View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-menu-divider.sky View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-menu-item.sky View 1 chunk +0 lines, -82 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-radio.sky View 1 chunk +0 lines, -112 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-scrollable.sky View 1 chunk +0 lines, -162 lines 0 comments Download
D sky/sdk/lib/framework/elements/sky-toolbar.sky View 1 chunk +0 lines, -33 lines 0 comments Download
D sky/tests/resources/test-element.sky View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-17 02:15:09 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-06-17 16:50:41 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-17 17:05:08 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8af9c19a601aaa3b93ff21903f7a84ac4ff2db98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698