Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1177843007: Invalidate GrTexture mipmap on content change notification (Closed)

Created:
5 years, 6 months ago by Justin Novosad
Modified:
5 years, 6 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Invalidate GrTexture mipmap on content change notification This fix is necessary to correctly propagate invalidations that are external to skia. For example, when drawing video or WebGL into a 2D canvas in Chrome, with mipmaps enabled. BUG=crbug.com/498356 TEST=GrTextureMipMapInvalidationTest Committed: https://skia.googlesource.com/skia/+/da5469d7bc0dc089d098f5a64a818ed079cc0930

Patch Set 1 #

Patch Set 2 : typo fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M include/core/SkPixelRef.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkPixelRef.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
A tests/GrTextureMipMapInvalidationTest.cpp View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Justin Novosad
PTAL
5 years, 6 months ago (2015-06-11 18:01:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177843007/1
5 years, 6 months ago (2015-06-11 18:02:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-11 18:07:43 UTC) #6
bsalomon
lgtm, but reed@ for change to SkPixelRef interface.
5 years, 6 months ago (2015-06-11 18:14:42 UTC) #8
Justin Novosad
reed@: review ping.
5 years, 6 months ago (2015-06-15 14:04:24 UTC) #9
reed1
lgtm
5 years, 6 months ago (2015-06-15 16:07:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177843007/20001
5 years, 6 months ago (2015-06-15 16:42:42 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 16:48:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/da5469d7bc0dc089d098f5a64a818ed079cc0930

Powered by Google App Engine
This is Rietveld 408576698