Issue 1177843006: Fixes a bug in that caused IceAssembler to use Allocator before it was initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177843006: Fixes a bug in that caused IceAssembler to use Allocator before it was initialized. (Closed)

Created:
5 years, 6 months ago by John

Modified:
5 years, 6 months ago

Reviewers:
jvoung (off chromium), kschimpf, Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fixes a bug in that caused IceAssembler to use Allocator before it was initialized. Initializes IceAssembler::Allocator before IceAssembler::Buffer. BUG= None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1a9043e71827183679814c99f375ef5a2a6f15ad

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	src/IceAssembler.h	View		3 chunks	+8 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

John

5 years, 6 months ago (2015-06-11 16:35:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1a9043e71827183679814c99f375ef5a2a6f15ad (presubmit successful).