src/core/SkTypeface.cpp - Issue 1177833004: Avoid unnecessary comparison if both Typeface are NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkTypeface.cpp

Issue 1177833004: Avoid unnecessary comparison if both Typeface are NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkTypeface.cpp

diff --git a/src/core/SkTypeface.cpp b/src/core/SkTypeface.cpp

index fcbb7452d0297e4e5add82ff4ac5c222553bf36a..2c7db68d87534701a821bd6e68f1d1b75d26b93f 100644

--- a/src/core/SkTypeface.cpp

+++ b/src/core/SkTypeface.cpp

@@ -107,7 +107,7 @@ uint32_t SkTypeface::UniqueID(const SkTypeface* face) {

}

bool SkTypeface::Equal(const SkTypeface* facea, const SkTypeface* faceb) {

- return SkTypeface::UniqueID(facea) == SkTypeface::UniqueID(faceb);

+ return facea == faceb || SkTypeface::UniqueID(facea) == SkTypeface::UniqueID(faceb);

}

///////////////////////////////////////////////////////////////////////////////

« no previous file with comments | « no previous file | no next file » | no next file with comments »